Compare commits
1
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
b79bba3911 |
+7
-7
@@ -1719,12 +1719,12 @@ issue #3 未关闭,`feat/fix-3-downlink-deadlock` 未合入 `main`。下面是
|
|||||||
- 备选方案:为每个未测子项补验收用例(本波不做,避免为变绿放松断言)。
|
- 备选方案:为每个未测子项补验收用例(本波不做,避免为变绿放松断言)。
|
||||||
- 影响:汇总改为通过 19、部分通过 4(F03/F08/F21/F22)、失败 0。F19 仍引用仓库内 SDK 清单、本波不重跑。
|
- 影响:汇总改为通过 19、部分通过 4(F03/F08/F21/F22)、失败 0。F19 仍引用仓库内 SDK 清单、本波不重跑。
|
||||||
|
|
||||||
### 复审修复 R3-06
|
### 复审修复 R3-01
|
||||||
|
|
||||||
1. **Python/Java 首次握手失败应停止重连;Java rate_limited 在途计数只减一次**
|
1. **推送 worker 漏唤醒:定时分发回执、超限后续、撤回腾窗**
|
||||||
- 日期:2026-09-30
|
- 日期:2026-09-30
|
||||||
- 原条款:DEVELOPMENT 第 9 节附录「首次连接超时或握手失败应停止重连,并向 connect() 返回未连接」;issue #70。
|
- 原条款:Gitea #65;推送 worker 只在 `WakePush` 时跑一轮 `PushPending`。
|
||||||
- 实际做法:`sdk/python` 的 `connect()` 在 `_handshake_error` 或非 ONLINE 终态时置 `_stop_reconnect`/`_want_connected=False`;内部连接/握手超时改用 `not_connected`(不再用 `busy`)。`sdk/java` 的 `connectSync` 在 `handshakeError` 时同样置 `stopReconnect`;`rate_limited` 路径去掉第二次 `inflightSends--`,只换新 rid 再排队。Python `transport.py` 将 paho 改为惰性导入,便于本机无 paho 时仍跑 FakeTransport 单测。不改 Go/JS 重连公式。
|
- 实际做法:`dispatchDueBatch` 本条已分发时除 pending 接收方外始终 `WakePush` 发送方;`PushPending` 遇 `too_large` 等跳过且本轮未占满窗口时再 `WakePush` 当前接收方(不在同一次递归扫表);`Recall` 成功改成 `recalled` 的接收方各 `WakePush` 一次,已推送撤回仍走 `flushRevokes`。不改 `PublishDown` 签名。
|
||||||
- 原因:原先抛错后工作线程仍按退避重连;Java 限速把在途计数减了两次。
|
- 原因:终态回执、超限后的后续 pending、撤回腾出窗口后都依赖再唤醒,否则空闲在线端收不到。
|
||||||
- 备选方案:在后台 `_attempt_connect`/`attemptConnect` 内首次失败即停(否决:应用再次 `connect()` 才应恢复,标志应在对外 `connect` 失败路径统一置位)。
|
- 备选方案:在同一次 `PushPending` 里循环扫完整 pending 表(否决,指令要求合并唤醒下一轮)。
|
||||||
- 影响:仅 `sdk/python`、`sdk/java`;应用需再次调用 `connect()` 才会重连。
|
- 影响:仅 `internal/app/message/`;相关单测见 `review_r3_65_test.go`。
|
||||||
|
|||||||
@@ -90,6 +90,7 @@ func (a *App) Recall(ctx context.Context, senderID string, req *protocol.Recall)
|
|||||||
nowMs := a.now().UnixMilli()
|
nowMs := a.now().UnixMilli()
|
||||||
var data protocol.RecallData
|
var data protocol.RecallData
|
||||||
var revokes []revokeJob
|
var revokes []revokeJob
|
||||||
|
var wakeReceivers []string
|
||||||
err := a.db.Queue.Do(ctx, func(tx *sql.Tx) error {
|
err := a.db.Queue.Do(ctx, func(tx *sql.Tx) error {
|
||||||
var seq int64
|
var seq int64
|
||||||
var state string
|
var state string
|
||||||
@@ -156,6 +157,7 @@ WHERE seq = ? AND endpoint_id = ? AND state = 'pending'`,
|
|||||||
continue
|
continue
|
||||||
}
|
}
|
||||||
recalled++
|
recalled++
|
||||||
|
wakeReceivers = append(wakeReceivers, p.ep)
|
||||||
if p.pushed.Valid && p.pushed.String != "" {
|
if p.pushed.Valid && p.pushed.String != "" {
|
||||||
revokes = append(revokes, revokeJob{
|
revokes = append(revokes, revokeJob{
|
||||||
endpointID: p.ep,
|
endpointID: p.ep,
|
||||||
@@ -190,6 +192,9 @@ SELECT COUNT(*) FROM deliveries WHERE seq = ? AND state IN ('expired','dropped',
|
|||||||
a.pendingRevoke = append(a.pendingRevoke, revokes...)
|
a.pendingRevoke = append(a.pendingRevoke, revokes...)
|
||||||
a.mu.Unlock()
|
a.mu.Unlock()
|
||||||
a.flushRevokes(ctx)
|
a.flushRevokes(ctx)
|
||||||
|
for _, ep := range wakeReceivers {
|
||||||
|
a.WakePush(ep)
|
||||||
|
}
|
||||||
return data, nil
|
return data, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -127,6 +127,7 @@ LIMIT ?`, nowMs, limit)
|
|||||||
}
|
}
|
||||||
mu.Lock()
|
mu.Lock()
|
||||||
n++
|
n++
|
||||||
|
wake[d.senderID] = struct{}{}
|
||||||
mu.Unlock()
|
mu.Unlock()
|
||||||
rows2, qErr := a.db.Read.QueryContext(ctx, `
|
rows2, qErr := a.db.Read.QueryContext(ctx, `
|
||||||
SELECT DISTINCT endpoint_id FROM deliveries WHERE seq = ? AND state = 'pending'`, d.seq)
|
SELECT DISTINCT endpoint_id FROM deliveries WHERE seq = ? AND state = 'pending'`, d.seq)
|
||||||
@@ -203,8 +204,10 @@ LIMIT ?`, endpointID, room)
|
|||||||
}
|
}
|
||||||
|
|
||||||
var toClaim []pushItem
|
var toClaim []pushItem
|
||||||
|
skipped := false
|
||||||
for _, it := range items {
|
for _, it := range items {
|
||||||
if it.body == nil {
|
if it.body == nil {
|
||||||
|
skipped = true
|
||||||
continue
|
continue
|
||||||
}
|
}
|
||||||
msg := protocol.Msg{
|
msg := protocol.Msg{
|
||||||
@@ -227,6 +230,7 @@ LIMIT ?`, endpointID, room)
|
|||||||
return rejErr
|
return rejErr
|
||||||
}
|
}
|
||||||
a.WakePush(it.senderID)
|
a.WakePush(it.senderID)
|
||||||
|
skipped = true
|
||||||
continue
|
continue
|
||||||
}
|
}
|
||||||
it.payload = payload
|
it.payload = payload
|
||||||
@@ -252,6 +256,10 @@ LIMIT ?`, endpointID, room)
|
|||||||
a.observeDispatchToPush(it.sendAt, nowMs)
|
a.observeDispatchToPush(it.sendAt, nowMs)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
// 超限等跳过未占满窗口时再唤醒本端,让 worker 下一轮取后续 pending(不在本轮递归扫表)。
|
||||||
|
if skipped && len(claimed) < room {
|
||||||
|
a.WakePush(endpointID)
|
||||||
|
}
|
||||||
return a.pushReceipts(ctx, endpointID, connID, nowMs)
|
return a.pushReceipts(ctx, endpointID, connID, nowMs)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -0,0 +1,180 @@
|
|||||||
|
package message
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
"database/sql"
|
||||||
|
"encoding/json"
|
||||||
|
"testing"
|
||||||
|
"time"
|
||||||
|
|
||||||
|
"git.asio.asia/nixevol/NixMsg/internal/app/port"
|
||||||
|
"git.asio.asia/nixevol/NixMsg/internal/protocol"
|
||||||
|
)
|
||||||
|
|
||||||
|
// 定时到点且接收方离线成终态时,在线发送方经 WakePush 拿到回执。
|
||||||
|
func TestR365DispatchDueWakesSenderForReceipt(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
e := openDeliveryEnv(t, nil)
|
||||||
|
insertEndpoint(t, e.db, "alice", "", 1, 0)
|
||||||
|
insertEndpoint(t, e.db, "bob", "", 1, 0)
|
||||||
|
_ = e.db.Queue.Do(context.Background(), func(tx *sql.Tx) error {
|
||||||
|
_, err := tx.Exec(`UPDATE endpoints SET offline_since = ? WHERE id=?`, e.nowMs-120_000, "bob")
|
||||||
|
return err
|
||||||
|
})
|
||||||
|
ctx := context.Background()
|
||||||
|
aliceConn := LiveConn{ConnID: "c-alice", Ready: true}
|
||||||
|
e.conns.Set("alice", aliceConn)
|
||||||
|
if err := e.app.OnHandshakeComplete(ctx, "alice", aliceConn); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
t.Cleanup(func() { e.app.stopPushWorker("alice", "") })
|
||||||
|
|
||||||
|
delay := int64(5000)
|
||||||
|
req := baseSend("due-rcpt", "bob")
|
||||||
|
req.DelayMs = &delay
|
||||||
|
if _, err := e.app.Submit(ctx, "alice", port.ConnInfo{}, req); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
st, _ := e.msgState("alice", "due-rcpt")
|
||||||
|
if st != StateScheduled {
|
||||||
|
t.Fatalf("want scheduled got %s", st)
|
||||||
|
}
|
||||||
|
if e.down.FilterType(protocol.TypeReceipt) != 0 {
|
||||||
|
t.Fatal("receipt before due")
|
||||||
|
}
|
||||||
|
|
||||||
|
e.setNow(e.nowMs + 5000)
|
||||||
|
if _, err := e.app.DispatchDue(ctx, e.nowMs, 10); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
deadline := time.Now().Add(2 * time.Second)
|
||||||
|
for time.Now().Before(deadline) {
|
||||||
|
if e.down.FilterType(protocol.TypeReceipt) > 0 {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
time.Sleep(20 * time.Millisecond)
|
||||||
|
}
|
||||||
|
t.Fatalf("sender got no receipt after scheduled dispatch, receipts=%d", e.down.FilterType(protocol.TypeReceipt))
|
||||||
|
}
|
||||||
|
|
||||||
|
// 窗口内首条超限拒收后,同连接后续小消息仍被 worker 推送。
|
||||||
|
func TestR365TooLargeThenSmallContinuesPush(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
e := openDeliveryEnv(t, func(l *Limits) { l.DeliveryWindow = 1 })
|
||||||
|
insertEndpoint(t, e.db, "alice", "", 1, 0)
|
||||||
|
insertEndpoint(t, e.db, "bob", "", 1, 0)
|
||||||
|
ctx := context.Background()
|
||||||
|
// 整帧上限:小消息能过,大正文整帧超限被拒。
|
||||||
|
bobConn := LiveConn{ConnID: "c-bob", Ready: true, MaxReceiveBytes: 200}
|
||||||
|
e.conns.Set("bob", bobConn)
|
||||||
|
if err := e.app.OnHandshakeComplete(ctx, "bob", bobConn); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
t.Cleanup(func() { e.app.stopPushWorker("bob", "") })
|
||||||
|
|
||||||
|
big := baseSend("big-skip", "bob")
|
||||||
|
b := make([]byte, 400)
|
||||||
|
for i := range b {
|
||||||
|
b[i] = 'A'
|
||||||
|
}
|
||||||
|
big.Body.Data = string(b)
|
||||||
|
if _, err := e.app.Submit(ctx, "alice", port.ConnInfo{}, big); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
small := baseSend("small-ok", "bob")
|
||||||
|
small.Body.Data = "hi"
|
||||||
|
if _, err := e.app.Submit(ctx, "alice", port.ConnInfo{}, small); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
|
||||||
|
deadline := time.Now().Add(2 * time.Second)
|
||||||
|
for time.Now().Before(deadline) {
|
||||||
|
foundSmall := false
|
||||||
|
for _, p := range e.down.Snapshots() {
|
||||||
|
if payloadType(p.Payload) != protocol.TypeMsg {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
var m struct {
|
||||||
|
ID string `json:"id"`
|
||||||
|
}
|
||||||
|
_ = json.Unmarshal(p.Payload, &m)
|
||||||
|
if m.ID == "small-ok" {
|
||||||
|
foundSmall = true
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if foundSmall {
|
||||||
|
seqBig := e.seqOf("alice", "big-skip")
|
||||||
|
st, reason := e.deliveryState(seqBig, "bob")
|
||||||
|
if st != DeliveryRejected || reason != ReasonTooLarge {
|
||||||
|
t.Fatalf("big: %s/%s", st, reason)
|
||||||
|
}
|
||||||
|
return
|
||||||
|
}
|
||||||
|
time.Sleep(20 * time.Millisecond)
|
||||||
|
}
|
||||||
|
t.Fatalf("small msg not pushed after too_large; msgs=%d snapshots=%d",
|
||||||
|
e.down.FilterType(protocol.TypeMsg), len(e.down.Snapshots()))
|
||||||
|
}
|
||||||
|
|
||||||
|
// 撤回已推在途消息后,同连接更晚的 pending 继续推。
|
||||||
|
func TestR365RecallFreesWindowForLaterPending(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
e := openDeliveryEnv(t, func(l *Limits) { l.DeliveryWindow = 1 })
|
||||||
|
insertEndpoint(t, e.db, "alice", "", 1, 0)
|
||||||
|
insertEndpoint(t, e.db, "bob", "", 1, 0)
|
||||||
|
ctx := context.Background()
|
||||||
|
bobConn := LiveConn{ConnID: "c-bob", Ready: true}
|
||||||
|
e.conns.Set("bob", bobConn)
|
||||||
|
if err := e.app.OnHandshakeComplete(ctx, "bob", bobConn); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
t.Cleanup(func() { e.app.stopPushWorker("bob", "") })
|
||||||
|
|
||||||
|
if _, err := e.app.Submit(ctx, "alice", port.ConnInfo{}, baseSend("first-in-flight", "bob")); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if _, err := e.app.Submit(ctx, "alice", port.ConnInfo{}, baseSend("second-wait", "bob")); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
|
||||||
|
deadline := time.Now().Add(2 * time.Second)
|
||||||
|
for time.Now().Before(deadline) {
|
||||||
|
if e.down.FilterType(protocol.TypeMsg) >= 1 {
|
||||||
|
break
|
||||||
|
}
|
||||||
|
time.Sleep(10 * time.Millisecond)
|
||||||
|
}
|
||||||
|
if e.down.FilterType(protocol.TypeMsg) < 1 {
|
||||||
|
t.Fatal("first msg not pushed")
|
||||||
|
}
|
||||||
|
seq1 := e.seqOf("alice", "first-in-flight")
|
||||||
|
var pushed sql.NullString
|
||||||
|
_ = e.db.Read.QueryRow(`SELECT pushed_conn FROM deliveries WHERE seq=? AND endpoint_id='bob'`, seq1).Scan(&pushed)
|
||||||
|
if !pushed.Valid {
|
||||||
|
t.Fatal("first not in-flight")
|
||||||
|
}
|
||||||
|
|
||||||
|
if _, err := e.app.Recall(ctx, "alice", &protocol.Recall{
|
||||||
|
V: protocol.Version, Type: protocol.TypeRecall, RID: "r1", ID: "first-in-flight",
|
||||||
|
}); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
|
||||||
|
deadline = time.Now().Add(2 * time.Second)
|
||||||
|
for time.Now().Before(deadline) {
|
||||||
|
for _, p := range e.down.Snapshots() {
|
||||||
|
if payloadType(p.Payload) != protocol.TypeMsg {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
var m struct {
|
||||||
|
ID string `json:"id"`
|
||||||
|
}
|
||||||
|
_ = json.Unmarshal(p.Payload, &m)
|
||||||
|
if m.ID == "second-wait" {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
}
|
||||||
|
time.Sleep(20 * time.Millisecond)
|
||||||
|
}
|
||||||
|
t.Fatalf("second pending not pushed after recall; msgs=%d", e.down.FilterType(protocol.TypeMsg))
|
||||||
|
}
|
||||||
@@ -143,12 +143,6 @@ public final class Client {
|
|||||||
return lastStopCode == null ? "" : lastStopCode;
|
return lastStopCode == null ? "" : lastStopCode;
|
||||||
}
|
}
|
||||||
|
|
||||||
int inflightSendsForTest() {
|
|
||||||
synchronized (lock) {
|
|
||||||
return inflightSends;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
void setSendQueueLimitForTest(int n) {
|
void setSendQueueLimitForTest(int n) {
|
||||||
sendQueueLimit = n;
|
sendQueueLimit = n;
|
||||||
}
|
}
|
||||||
@@ -217,19 +211,6 @@ public final class Client {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
if (handshakeError != null) {
|
if (handshakeError != null) {
|
||||||
synchronized (lock) {
|
|
||||||
stopReconnect = true;
|
|
||||||
wantConnected = false;
|
|
||||||
if (lastStopCode == null || lastStopCode.isEmpty()) {
|
|
||||||
if (handshakeError instanceof NixMsgException) {
|
|
||||||
lastStopCode = ((NixMsgException) handshakeError).getCode();
|
|
||||||
lastStopErr = (NixMsgException) handshakeError;
|
|
||||||
} else {
|
|
||||||
lastStopCode = "not_connected";
|
|
||||||
lastStopErr = new NixMsgException("not_connected", handshakeError.getMessage());
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
if (handshakeError instanceof NixMsgException) {
|
if (handshakeError instanceof NixMsgException) {
|
||||||
throw (NixMsgException) handshakeError;
|
throw (NixMsgException) handshakeError;
|
||||||
}
|
}
|
||||||
@@ -248,8 +229,6 @@ public final class Client {
|
|||||||
synchronized (lock) {
|
synchronized (lock) {
|
||||||
stopReconnect = true;
|
stopReconnect = true;
|
||||||
wantConnected = false;
|
wantConnected = false;
|
||||||
lastStopCode = "not_connected";
|
|
||||||
lastStopErr = new NixMsgException("not_connected", "连接未成功: " + state);
|
|
||||||
}
|
}
|
||||||
throw new NixMsgException("not_connected", "连接未成功: " + state);
|
throw new NixMsgException("not_connected", "连接未成功: " + state);
|
||||||
}
|
}
|
||||||
@@ -725,9 +704,7 @@ public final class Client {
|
|||||||
transport.publish(Protocol.upTopic(endpointId), Protocol.dumps(hello));
|
transport.publish(Protocol.upTopic(endpointId), Protocol.dumps(hello));
|
||||||
await(p.future, connectTimeoutMs);
|
await(p.future, connectTimeoutMs);
|
||||||
if (p.error != null) {
|
if (p.error != null) {
|
||||||
throw p.error instanceof RuntimeException
|
throw p.error instanceof RuntimeException ? (RuntimeException) p.error : new NixMsgException("busy", p.error.getMessage());
|
||||||
? (RuntimeException) p.error
|
|
||||||
: new NixMsgException("not_connected", p.error.getMessage());
|
|
||||||
}
|
}
|
||||||
if (p.response == null) {
|
if (p.response == null) {
|
||||||
throw new NixMsgException("not_connected", "握手超时");
|
throw new NixMsgException("not_connected", "握手超时");
|
||||||
@@ -906,9 +883,9 @@ public final class Client {
|
|||||||
if (!Boolean.TRUE.equals(frame.get("ok"))) {
|
if (!Boolean.TRUE.equals(frame.get("ok"))) {
|
||||||
Map<String, Object> err = asMap(frame.get("error"));
|
Map<String, Object> err = asMap(frame.get("error"));
|
||||||
if ("rate_limited".equals(str(err.get("code"), ""))) {
|
if ("rate_limited".equals(str(err.get("code"), ""))) {
|
||||||
// 在途计数已在上方减过一次;只换新 rid 再排队,勿再减。
|
|
||||||
synchronized (lock) {
|
synchronized (lock) {
|
||||||
pending.remove(rid);
|
pending.remove(rid);
|
||||||
|
inflightSends = Math.max(0, inflightSends - 1);
|
||||||
p.rid = "";
|
p.rid = "";
|
||||||
p.response = null;
|
p.response = null;
|
||||||
p.error = null;
|
p.error = null;
|
||||||
|
|||||||
@@ -41,7 +41,7 @@ public class K00Test {
|
|||||||
}
|
}
|
||||||
|
|
||||||
@Test
|
@Test
|
||||||
public void testK00FirstConnectTimeout() throws Exception {
|
public void testK00FirstConnectTimeout() {
|
||||||
FakeTransport tr = new FakeTransport();
|
FakeTransport tr = new FakeTransport();
|
||||||
tr.autoHello = null;
|
tr.autoHello = null;
|
||||||
client = new Client(tr, true, Types.DEFAULT_MAX_FRAME, Types.CLIENT_NAME, 150);
|
client = new Client(tr, true, Types.DEFAULT_MAX_FRAME, Types.CLIENT_NAME, 150);
|
||||||
@@ -51,9 +51,6 @@ public class K00Test {
|
|||||||
} catch (NixMsgException e) {
|
} catch (NixMsgException e) {
|
||||||
assertEquals("not_connected", e.getCode());
|
assertEquals("not_connected", e.getCode());
|
||||||
}
|
}
|
||||||
int n = tr.connects.size();
|
|
||||||
Thread.sleep(350);
|
|
||||||
assertEquals("首次握手失败后不得自动重连", n, tr.connects.size());
|
|
||||||
tr.autoHello = new LinkedHashMap<String, Object>();
|
tr.autoHello = new LinkedHashMap<String, Object>();
|
||||||
tr.autoHello.put("server_time_ms", 1750000000000L);
|
tr.autoHello.put("server_time_ms", 1750000000000L);
|
||||||
tr.autoHello.put("server_version", "0.1.0");
|
tr.autoHello.put("server_version", "0.1.0");
|
||||||
@@ -66,108 +63,6 @@ public class K00Test {
|
|||||||
tr.autoHello.put("session_token", "nst_test_token");
|
tr.autoHello.put("session_token", "nst_test_token");
|
||||||
client.connectSync("ws://example.test/mqtt", "ep1", "p", null, false);
|
client.connectSync("ws://example.test/mqtt", "ep1", "p", null, false);
|
||||||
assertEquals(ConnectionState.ONLINE, client.getState());
|
assertEquals(ConnectionState.ONLINE, client.getState());
|
||||||
assertTrue(tr.connects.size() > n);
|
|
||||||
}
|
|
||||||
|
|
||||||
@Test
|
|
||||||
public void testK00RateLimitedInflightOnce() throws Exception {
|
|
||||||
Types.ReconnectBackoff.disableJitterForTest();
|
|
||||||
FakeTransport tr = new FakeTransport();
|
|
||||||
tr.autoSendOk = false;
|
|
||||||
final List<String> holdRids = new CopyOnWriteArrayList<String>();
|
|
||||||
final List<String> limitedRids = new CopyOnWriteArrayList<String>();
|
|
||||||
tr.onUp(new java.util.function.Function<Map<String, Object>, Map<String, Object>>() {
|
|
||||||
@Override
|
|
||||||
public Map<String, Object> apply(Map<String, Object> frame) {
|
|
||||||
if (!"send".equals(String.valueOf(frame.get("type")))) {
|
|
||||||
return null;
|
|
||||||
}
|
|
||||||
String rid = String.valueOf(frame.get("rid"));
|
|
||||||
String id = String.valueOf(frame.get("id"));
|
|
||||||
if ("hold".equals(id)) {
|
|
||||||
holdRids.add(rid);
|
|
||||||
return null; // 保持在途
|
|
||||||
}
|
|
||||||
limitedRids.add(rid);
|
|
||||||
if (limitedRids.size() == 1) {
|
|
||||||
Map<String, Object> err = new LinkedHashMap<String, Object>();
|
|
||||||
err.put("code", "rate_limited");
|
|
||||||
err.put("message", "slow");
|
|
||||||
Map<String, Object> resp = new LinkedHashMap<String, Object>();
|
|
||||||
resp.put("v", 1);
|
|
||||||
resp.put("type", "resp");
|
|
||||||
resp.put("rid", rid);
|
|
||||||
resp.put("ok", false);
|
|
||||||
resp.put("error", err);
|
|
||||||
return resp;
|
|
||||||
}
|
|
||||||
Map<String, Object> data = new LinkedHashMap<String, Object>();
|
|
||||||
data.put("id", frame.get("id"));
|
|
||||||
data.put("send_at_ms", frame.get("send_at_ms"));
|
|
||||||
data.put("state", "scheduled");
|
|
||||||
Map<String, Object> resp = new LinkedHashMap<String, Object>();
|
|
||||||
resp.put("v", 1);
|
|
||||||
resp.put("type", "resp");
|
|
||||||
resp.put("rid", rid);
|
|
||||||
resp.put("ok", true);
|
|
||||||
resp.put("data", data);
|
|
||||||
return resp;
|
|
||||||
}
|
|
||||||
});
|
|
||||||
connectOnline(tr);
|
|
||||||
Thread holder = new Thread(new Runnable() {
|
|
||||||
@Override
|
|
||||||
public void run() {
|
|
||||||
try {
|
|
||||||
SendOptions opt = new SendOptions();
|
|
||||||
opt.messageId = "hold";
|
|
||||||
opt.sendAtMs = 1700000000001L;
|
|
||||||
client.sendSync(new Target("endpoint", "ep2"), new Body("hold"), opt);
|
|
||||||
} catch (Exception ignored) {
|
|
||||||
}
|
|
||||||
}
|
|
||||||
});
|
|
||||||
holder.setDaemon(true);
|
|
||||||
holder.start();
|
|
||||||
long deadline = System.currentTimeMillis() + 2000;
|
|
||||||
while (holdRids.isEmpty() && System.currentTimeMillis() < deadline) {
|
|
||||||
Thread.sleep(10);
|
|
||||||
}
|
|
||||||
assertFalse(holdRids.isEmpty());
|
|
||||||
assertEquals(1, client.inflightSendsForTest());
|
|
||||||
final SendOptions opt = new SendOptions();
|
|
||||||
opt.messageId = "lim";
|
|
||||||
opt.sendAtMs = 1700000000002L;
|
|
||||||
Thread sender = new Thread(new Runnable() {
|
|
||||||
@Override
|
|
||||||
public void run() {
|
|
||||||
try {
|
|
||||||
client.sendSync(new Target("endpoint", "ep2"), new Body("lim"), opt);
|
|
||||||
} catch (Exception ignored) {
|
|
||||||
}
|
|
||||||
}
|
|
||||||
});
|
|
||||||
sender.setDaemon(true);
|
|
||||||
sender.start();
|
|
||||||
deadline = System.currentTimeMillis() + 3000;
|
|
||||||
while (limitedRids.size() < 1 && System.currentTimeMillis() < deadline) {
|
|
||||||
Thread.sleep(10);
|
|
||||||
}
|
|
||||||
assertTrue(limitedRids.size() >= 1);
|
|
||||||
// rate_limited 后只应减 1:仍剩 hold 那一条在途
|
|
||||||
deadline = System.currentTimeMillis() + 500;
|
|
||||||
int seen = -1;
|
|
||||||
while (System.currentTimeMillis() < deadline) {
|
|
||||||
seen = client.inflightSendsForTest();
|
|
||||||
if (seen == 1) {
|
|
||||||
break;
|
|
||||||
}
|
|
||||||
Thread.sleep(10);
|
|
||||||
}
|
|
||||||
assertEquals("rate_limited 后在途应只减 1", 1, seen);
|
|
||||||
client.close();
|
|
||||||
holder.join(1000);
|
|
||||||
sender.join(1000);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
@Test
|
@Test
|
||||||
|
|||||||
@@ -227,15 +227,6 @@ class Client:
|
|||||||
raise NixMsgError("not_connected", "连接超时")
|
raise NixMsgError("not_connected", "连接超时")
|
||||||
err = self._handshake_error
|
err = self._handshake_error
|
||||||
if err:
|
if err:
|
||||||
with self._lock:
|
|
||||||
self._stop_reconnect = True
|
|
||||||
self._want_connected = False
|
|
||||||
if not self._last_stop_code:
|
|
||||||
code = getattr(err, "code", None) or "not_connected"
|
|
||||||
self._last_stop_code = str(code)
|
|
||||||
self._last_stop_err = err if isinstance(err, NixMsgError) else NixMsgError(
|
|
||||||
"not_connected", str(err)
|
|
||||||
)
|
|
||||||
raise err
|
raise err
|
||||||
if self._state not in (ConnectionState.ONLINE,):
|
if self._state not in (ConnectionState.ONLINE,):
|
||||||
if self._state == ConnectionState.AUTH_FAILED:
|
if self._state == ConnectionState.AUTH_FAILED:
|
||||||
@@ -245,11 +236,6 @@ class Client:
|
|||||||
)
|
)
|
||||||
if self._state == ConnectionState.KICKED:
|
if self._state == ConnectionState.KICKED:
|
||||||
raise NixMsgError("taken_over", "会话被接管")
|
raise NixMsgError("taken_over", "会话被接管")
|
||||||
with self._lock:
|
|
||||||
self._stop_reconnect = True
|
|
||||||
self._want_connected = False
|
|
||||||
self._last_stop_code = "not_connected"
|
|
||||||
self._last_stop_err = NixMsgError("not_connected", f"连接未成功: {self._state.value}")
|
|
||||||
raise NixMsgError("not_connected", f"连接未成功: {self._state.value}")
|
raise NixMsgError("not_connected", f"连接未成功: {self._state.value}")
|
||||||
|
|
||||||
def close(self) -> None:
|
def close(self) -> None:
|
||||||
@@ -590,7 +576,7 @@ class Client:
|
|||||||
except Exception:
|
except Exception:
|
||||||
pass
|
pass
|
||||||
with self._lock:
|
with self._lock:
|
||||||
self._handshake_error = NixMsgError("not_connected", "连接超时")
|
self._handshake_error = NixMsgError("busy", "连接超时")
|
||||||
return
|
return
|
||||||
|
|
||||||
def _on_transport_connected(self) -> None:
|
def _on_transport_connected(self) -> None:
|
||||||
@@ -612,7 +598,7 @@ class Client:
|
|||||||
self._pending[rid] = pending
|
self._pending[rid] = pending
|
||||||
self._transport.publish(up_topic(self._endpoint_id), dumps(hello))
|
self._transport.publish(up_topic(self._endpoint_id), dumps(hello))
|
||||||
if not pending.event.wait(self._connect_timeout_s):
|
if not pending.event.wait(self._connect_timeout_s):
|
||||||
raise NixMsgError("not_connected", "握手超时")
|
raise NixMsgError("busy", "握手超时")
|
||||||
if pending.error:
|
if pending.error:
|
||||||
raise pending.error
|
raise pending.error
|
||||||
assert pending.response is not None
|
assert pending.response is not None
|
||||||
|
|||||||
@@ -8,23 +8,16 @@ from dataclasses import dataclass, field
|
|||||||
from typing import Any, Callable, Optional, Protocol
|
from typing import Any, Callable, Optional, Protocol
|
||||||
from urllib.parse import urlparse
|
from urllib.parse import urlparse
|
||||||
|
|
||||||
|
from paho.mqtt.client import CallbackAPIVersion, Client as PahoClient, MQTT_ERR_SUCCESS, MQTTv5
|
||||||
|
from paho.mqtt.enums import MQTTErrorCode
|
||||||
|
from paho.mqtt.reasoncodes import ReasonCode
|
||||||
|
|
||||||
DownHandler = Callable[[bytes], None]
|
DownHandler = Callable[[bytes], None]
|
||||||
ConnHandler = Callable[[], None]
|
ConnHandler = Callable[[], None]
|
||||||
DiscHandler = Callable[[Optional[str], bool], None]
|
DiscHandler = Callable[[Optional[str], bool], None]
|
||||||
# reason_code_str, stop_reconnect
|
# reason_code_str, stop_reconnect
|
||||||
|
|
||||||
|
|
||||||
def _require_paho():
|
|
||||||
"""真实 MQTT 路径才加载 paho;假传输单测不依赖。"""
|
|
||||||
try:
|
|
||||||
from paho.mqtt.client import CallbackAPIVersion, Client as PahoClient, MQTT_ERR_SUCCESS, MQTTv5
|
|
||||||
from paho.mqtt.enums import MQTTErrorCode
|
|
||||||
from paho.mqtt.reasoncodes import ReasonCode
|
|
||||||
except ImportError as e:
|
|
||||||
raise ImportError("需要 paho-mqtt>=2.0(真实 MQTT 连接)") from e
|
|
||||||
return CallbackAPIVersion, PahoClient, MQTT_ERR_SUCCESS, MQTTv5, MQTTErrorCode, ReasonCode
|
|
||||||
|
|
||||||
|
|
||||||
@dataclass
|
@dataclass
|
||||||
class ConnectParams:
|
class ConnectParams:
|
||||||
url: str
|
url: str
|
||||||
@@ -187,7 +180,7 @@ class PahoTransport:
|
|||||||
"""paho-mqtt 2.x CallbackAPIVersion.VERSION2。"""
|
"""paho-mqtt 2.x CallbackAPIVersion.VERSION2。"""
|
||||||
|
|
||||||
def __init__(self) -> None:
|
def __init__(self) -> None:
|
||||||
self._client: Any = None
|
self._client: Optional[PahoClient] = None
|
||||||
self._on_connected: Optional[ConnHandler] = None
|
self._on_connected: Optional[ConnHandler] = None
|
||||||
self._on_disconnected: Optional[DiscHandler] = None
|
self._on_disconnected: Optional[DiscHandler] = None
|
||||||
self._on_down: Optional[DownHandler] = None
|
self._on_down: Optional[DownHandler] = None
|
||||||
@@ -207,7 +200,6 @@ class PahoTransport:
|
|||||||
self._on_down = on_down
|
self._on_down = on_down
|
||||||
|
|
||||||
def connect(self, params: ConnectParams) -> None:
|
def connect(self, params: ConnectParams) -> None:
|
||||||
CallbackAPIVersion, PahoClient, _, MQTTv5, _, _ = _require_paho()
|
|
||||||
self.disconnect()
|
self.disconnect()
|
||||||
url = params.url
|
url = params.url
|
||||||
u = urlparse(url if "://" in url else "ws://" + url)
|
u = urlparse(url if "://" in url else "ws://" + url)
|
||||||
@@ -269,7 +261,6 @@ class PahoTransport:
|
|||||||
# 等待连接结果由回调驱动;超时由 Client 层处理
|
# 等待连接结果由回调驱动;超时由 Client 层处理
|
||||||
|
|
||||||
def subscribe(self, topic: str) -> None:
|
def subscribe(self, topic: str) -> None:
|
||||||
_, _, MQTT_ERR_SUCCESS, _, _, _ = _require_paho()
|
|
||||||
self._down_topic = topic
|
self._down_topic = topic
|
||||||
if not self._client:
|
if not self._client:
|
||||||
return
|
return
|
||||||
@@ -282,7 +273,6 @@ class PahoTransport:
|
|||||||
raise RuntimeError("subscribe timeout")
|
raise RuntimeError("subscribe timeout")
|
||||||
|
|
||||||
def publish(self, topic: str, payload: bytes) -> None:
|
def publish(self, topic: str, payload: bytes) -> None:
|
||||||
_, _, MQTT_ERR_SUCCESS, _, _, _ = _require_paho()
|
|
||||||
if not self._client:
|
if not self._client:
|
||||||
raise RuntimeError("not connected")
|
raise RuntimeError("not connected")
|
||||||
info = self._client.publish(topic, payload, qos=1)
|
info = self._client.publish(topic, payload, qos=1)
|
||||||
@@ -348,14 +338,9 @@ def _reason_to_int(reason_code) -> Optional[int]:
|
|||||||
return None
|
return None
|
||||||
if isinstance(reason_code, int):
|
if isinstance(reason_code, int):
|
||||||
return reason_code
|
return reason_code
|
||||||
try:
|
if isinstance(reason_code, ReasonCode):
|
||||||
_, _, _, _, MQTTErrorCode, ReasonCode = _require_paho()
|
|
||||||
except ImportError:
|
|
||||||
MQTTErrorCode = () # type: ignore[assignment,misc]
|
|
||||||
ReasonCode = () # type: ignore[assignment,misc]
|
|
||||||
if ReasonCode and isinstance(reason_code, ReasonCode):
|
|
||||||
return int(reason_code.value)
|
return int(reason_code.value)
|
||||||
if MQTTErrorCode and isinstance(reason_code, MQTTErrorCode):
|
if isinstance(reason_code, MQTTErrorCode):
|
||||||
return int(reason_code)
|
return int(reason_code)
|
||||||
# paho 偶发其它包装
|
# paho 偶发其它包装
|
||||||
val = getattr(reason_code, "value", None)
|
val = getattr(reason_code, "value", None)
|
||||||
|
|||||||
@@ -30,42 +30,11 @@ class K00Tests(unittest.TestCase):
|
|||||||
with self.assertRaises(NixMsgError) as cm:
|
with self.assertRaises(NixMsgError) as cm:
|
||||||
c.connect("ws://example.test/mqtt", "ep1", password="p", wait=True)
|
c.connect("ws://example.test/mqtt", "ep1", password="p", wait=True)
|
||||||
self.assertEqual(cm.exception.code, "not_connected")
|
self.assertEqual(cm.exception.code, "not_connected")
|
||||||
n = len(tr.connects)
|
|
||||||
time.sleep(0.35)
|
|
||||||
self.assertEqual(len(tr.connects), n, "首次失败后不得自动重连")
|
|
||||||
tr.auto_accept = True
|
tr.auto_accept = True
|
||||||
c.connect("ws://example.test/mqtt", "ep1", password="p", wait=True)
|
c.connect("ws://example.test/mqtt", "ep1", password="p", wait=True)
|
||||||
self.assertEqual(c.state, ConnectionState.ONLINE)
|
self.assertEqual(c.state, ConnectionState.ONLINE)
|
||||||
c.close()
|
c.close()
|
||||||
|
|
||||||
def test_k00_first_hello_fail_stops_reconnect(self) -> None:
|
|
||||||
"""MQTT 已通但 hello 失败:connect 返回未连接,且后台不再连。"""
|
|
||||||
tr = FakeTransport()
|
|
||||||
tr.auto_hello = None
|
|
||||||
c = Client(transport=tr, connect_timeout_s=0.2)
|
|
||||||
with self.assertRaises(NixMsgError) as cm:
|
|
||||||
c.connect("ws://example.test/mqtt", "ep1", password="p", wait=True)
|
|
||||||
self.assertEqual(cm.exception.code, "not_connected")
|
|
||||||
n = len(tr.connects)
|
|
||||||
self.assertGreaterEqual(n, 1)
|
|
||||||
time.sleep(0.45)
|
|
||||||
self.assertEqual(len(tr.connects), n, "hello 失败后不得自动重连")
|
|
||||||
tr.auto_hello = {
|
|
||||||
"server_time_ms": 1_750_000_000_000,
|
|
||||||
"server_version": "0.1.0",
|
|
||||||
"max_body_bytes": 262144,
|
|
||||||
"max_meta_bytes": 4096,
|
|
||||||
"max_frame_bytes": 786432,
|
|
||||||
"max_ttl_seconds": 2592000,
|
|
||||||
"max_schedule_seconds": 31536000,
|
|
||||||
"ack_timeout_seconds": 300,
|
|
||||||
"session_token": "nst_retry",
|
|
||||||
}
|
|
||||||
c.connect("ws://example.test/mqtt", "ep1", password="p", wait=True)
|
|
||||||
self.assertEqual(c.state, ConnectionState.ONLINE)
|
|
||||||
self.assertGreater(len(tr.connects), n)
|
|
||||||
c.close()
|
|
||||||
|
|
||||||
def test_k00_taken_over_reason(self) -> None:
|
def test_k00_taken_over_reason(self) -> None:
|
||||||
c, tr = self._connect()
|
c, tr = self._connect()
|
||||||
got = []
|
got = []
|
||||||
|
|||||||
Reference in New Issue
Block a user