Compare commits
1
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
a14ca0d08d |
+3
-1
@@ -335,7 +335,9 @@ func runServe(ctx context.Context, cfg config.Config) error {
|
||||
drainCancel()
|
||||
|
||||
shutCtx, shutCancel := context.WithTimeout(context.Background(), 5*time.Second)
|
||||
_ = brk.Shutdown(shutCtx)
|
||||
if shutErr := brk.Shutdown(shutCtx); shutErr != nil && !errors.Is(shutErr, context.DeadlineExceeded) && !errors.Is(shutErr, context.Canceled) {
|
||||
slog.Error("broker shutdown", "err", shutErr)
|
||||
}
|
||||
shutCancel()
|
||||
|
||||
secondDrain := drainBudget - time.Since(drainStart)
|
||||
|
||||
+8
-8
@@ -1719,12 +1719,12 @@ issue #3 未关闭,`feat/fix-3-downlink-deadlock` 未合入 `main`。下面是
|
||||
- 备选方案:为每个未测子项补验收用例(本波不做,避免为变绿放松断言)。
|
||||
- 影响:汇总改为通过 19、部分通过 4(F03/F08/F21/F22)、失败 0。F19 仍引用仓库内 SDK 清单、本波不重跑。
|
||||
|
||||
### ¸´ÉóÐÞ¸´ R3-03
|
||||
### 复审修复 R3-02
|
||||
|
||||
1. **д¶ÓÁÐÂúʱ Close ²»ÔÙÓë enqueue ËÀËø**
|
||||
- ÈÕÆÚ£º2026-09-30
|
||||
- ÔÌõ¿î£ºissue #67£»Í£»úÐè Drain/Close ÔÚ³¬Ê±ÄÚ·µ»Ø£»ÒÑÈë¶ÓÈÎÎñÈÔÓÉд goroutine ´¦ÀíÍê¡£
|
||||
- ʵ¼Ê×ö·¨£ºQueue Ôö¼Ó closing Ðźš£enqueue ÔÚ³Ö sendMu.RLock ʱ select ͬʱµÈ´ý q.ch¡¢closing Óë ctx.Done()£¬Í¨µÀÂúʱ²»ÔÙÎÞÏÞ×èÈû¡£Close ÏÈ Swap(closed) ²¢ close(closing) »½ÐÑÔÚ;·¢ËÍ·½ÊͷŶÁËø£¬ÔÙÔÚÐ´ËøÄÚ close(q.ch)£¬×îºóµÈ loop Í˳ö¡£²»ÏòÒÑ¹Ø±Õ channel ·¢ËÍ¡£
|
||||
- ÔÒò£ºÍ¨µÀÂúʱ²¢·¢ Do Õ¼×ŶÁËø¶ÂÔÚ·¢ËÍÉÏ£¬Close µÄÐ´ËøÄò»µ½£¬Í£»ú¿¨ËÀ£»Î´Ìá½»µÄÔÚ;дҲ»á¶ª¡£
|
||||
- ±¸Ñ¡·½°¸£ºÈë¶Ó¸ÄΪ·Ç×èÈû£¬ÂúÔòÁ¢¼´ ErrBusy£¨·ñ¾ö£º¸Ä±ä±³Ñ¹ÓïÒ壬Õý³£¸ß·å»áÎóÉËÌá½»£©¡£
|
||||
- Ó°Ï죺½ö internal/store/queue.go Óë²âÊÔ£»²»¸ÄÇ¨ÒÆ±àºÅ¡£
|
||||
1. **积压时 fatal/logout 与停机 0x8B 须等本帧写出**
|
||||
- 日期:2026-09-30
|
||||
- 原条款:Gitea #66;B-04 / B-08。
|
||||
- 实际做法:带断开的下行帧用本帧 `OnPacketSent` 完成信号(优先 packet id,否则按载荷匹配),不再用连接级 `sentPub` 总数。`Shutdown` 在 ctx 未取消时先等下行队列与 `wirePending` 排空,再 `DisconnectClient` 发 `0x8B` 并在截止前等连接拆掉;ctx 已取消则发完即 `Close`。`serve` 仍给 5 秒预算并记录非超时错误。未合 `feat/fix-3-downlink-deadlock`。
|
||||
- 原因:前面 PUBLISH 的 `OnPacketSent` 会让总数等待提前返回;`Shutdown` 对 ctx 非阻塞 select 使 5 秒预算用不上,有 outbound 积压时 `0x8B` 只进 outbuf 随 `Stop` 丢掉。
|
||||
- 备选方案:恢复固定 `Sleep`(否决);改 `PublishDown` 签名(否决)。
|
||||
- 影响:队列/outbound 有积压时 fatal、logout 先到客户端再断开;停机在预算内尽量发出 `0x8B`,超时返回 ctx 错误而非空等。
|
||||
|
||||
@@ -87,6 +87,50 @@ func TestPublishThenDisconnectWritesThenCloses(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
func TestPublishThenDisconnectAfterQueuedFrame(t *testing.T) {
|
||||
b, w, done := startTCPClient(t, "ep-ptd-q")
|
||||
defer func() { _ = b.Close() }()
|
||||
defer func() {
|
||||
_ = w.Close()
|
||||
select {
|
||||
case <-done:
|
||||
case <-time.After(3 * time.Second):
|
||||
}
|
||||
}()
|
||||
writeConnect(t, w, "ep-ptd-q", 30, 0)
|
||||
readExactPacket(t, w, packets.Connack, 3*time.Second)
|
||||
writeSubscribe(t, w, downTopic("ep-ptd-q"))
|
||||
readExactPacket(t, w, packets.Suback, 3*time.Second)
|
||||
waitSession(t, b, "ep-ptd-q")
|
||||
|
||||
first := []byte(`{"v":1,"type":"msg","id":"queued-ahead"}`)
|
||||
fatal := []byte(`{"v":1,"type":"fatal","reason":"disabled"}`)
|
||||
if err := b.PublishDown(context.Background(), "ep-ptd-q", "", first, port.PublishOpts{QoS: 1}); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if err := b.PublishThenDisconnect(context.Background(), "ep-ptd-q", "", fatal, 1, port.DisconnectFatal); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
gotFirst := readDownPayload(t, w, 3*time.Second)
|
||||
if !bytes.Equal(gotFirst, first) {
|
||||
t.Fatalf("first got %s", gotFirst)
|
||||
}
|
||||
gotFatal := readDownPayload(t, w, 3*time.Second)
|
||||
if !bytes.Equal(gotFatal, fatal) {
|
||||
t.Fatalf("fatal got %s want %s (disconnected before fatal frame)", gotFatal, fatal)
|
||||
}
|
||||
_ = w.SetReadDeadline(time.Now().Add(3 * time.Second))
|
||||
buf := make([]byte, 64)
|
||||
n, err := io.ReadAtLeast(w, buf, 2)
|
||||
if err != nil && n == 0 {
|
||||
return
|
||||
}
|
||||
if n > 0 && buf[0]>>4 == packets.Disconnect {
|
||||
return
|
||||
}
|
||||
}
|
||||
|
||||
func TestShutdownUsesServerShuttingDown(t *testing.T) {
|
||||
b, w, done := startTCPClient(t, "ep-shut")
|
||||
defer func() {
|
||||
@@ -116,6 +160,120 @@ func TestShutdownUsesServerShuttingDown(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
func TestShutdownWithBacklogDeliversServerShuttingDown(t *testing.T) {
|
||||
b, w, done := startTCPClient(t, "ep-shut-bl")
|
||||
defer func() {
|
||||
_ = w.Close()
|
||||
select {
|
||||
case <-done:
|
||||
case <-time.After(3 * time.Second):
|
||||
}
|
||||
}()
|
||||
writeConnect(t, w, "ep-shut-bl", 30, 0)
|
||||
readExactPacket(t, w, packets.Connack, 3*time.Second)
|
||||
writeSubscribe(t, w, downTopic("ep-shut-bl"))
|
||||
readExactPacket(t, w, packets.Suback, 3*time.Second)
|
||||
waitSession(t, b, "ep-shut-bl")
|
||||
|
||||
payload := bytes.Repeat([]byte("b"), 1024)
|
||||
for i := 0; i < 8; i++ {
|
||||
if err := b.PublishDown(context.Background(), "ep-shut-bl", "", payload, port.PublishOpts{QoS: 1}); err != nil {
|
||||
t.Fatalf("publish %d: %v", i, err)
|
||||
}
|
||||
}
|
||||
|
||||
saw8B := make(chan bool, 1)
|
||||
go func() {
|
||||
deadline := time.Now().Add(3 * time.Second)
|
||||
for time.Now().Before(deadline) {
|
||||
_ = w.SetReadDeadline(time.Now().Add(200 * time.Millisecond))
|
||||
hdr := make([]byte, 1)
|
||||
if _, err := io.ReadFull(w, hdr); err != nil {
|
||||
continue
|
||||
}
|
||||
rem, err := readRemainingLengthConn(w)
|
||||
if err != nil {
|
||||
continue
|
||||
}
|
||||
body := make([]byte, rem)
|
||||
if _, err := io.ReadFull(w, body); err != nil {
|
||||
continue
|
||||
}
|
||||
switch hdr[0] >> 4 {
|
||||
case packets.Publish:
|
||||
qos := (hdr[0] >> 1) & 0x3
|
||||
if qos > 0 {
|
||||
pk := new(packets.Packet)
|
||||
pk.ProtocolVersion = 5
|
||||
pk.FixedHeader = packets.FixedHeader{Type: packets.Publish, Remaining: rem, Qos: qos}
|
||||
if decErr := pk.PublishDecode(body); decErr == nil {
|
||||
ack := packets.Packet{
|
||||
FixedHeader: packets.FixedHeader{Type: packets.Puback},
|
||||
ProtocolVersion: 5,
|
||||
PacketID: pk.PacketID,
|
||||
}
|
||||
var ab bytes.Buffer
|
||||
_ = ack.PubackEncode(&ab)
|
||||
_, _ = w.Write(ab.Bytes())
|
||||
}
|
||||
}
|
||||
case packets.Disconnect:
|
||||
if rem >= 1 && body[0] == packets.ErrServerShuttingDown.Code {
|
||||
saw8B <- true
|
||||
return
|
||||
}
|
||||
}
|
||||
}
|
||||
saw8B <- false
|
||||
}()
|
||||
time.Sleep(20 * time.Millisecond)
|
||||
|
||||
ctx, cancel := context.WithTimeout(context.Background(), 3*time.Second)
|
||||
defer cancel()
|
||||
err := b.Shutdown(ctx)
|
||||
|
||||
got := false
|
||||
select {
|
||||
case got = <-saw8B:
|
||||
case <-time.After(4 * time.Second):
|
||||
t.Fatal("reader hung")
|
||||
}
|
||||
if got {
|
||||
if err != nil && !errors.Is(err, context.DeadlineExceeded) {
|
||||
t.Fatalf("shutdown after 0x8B: %v", err)
|
||||
}
|
||||
return
|
||||
}
|
||||
if err == nil {
|
||||
t.Fatal("expected 0x8B or shutdown deadline error, got neither")
|
||||
}
|
||||
if !errors.Is(err, context.DeadlineExceeded) && !errors.Is(err, context.Canceled) {
|
||||
t.Fatalf("shutdown err=%v want deadline/cancel when 0x8B not seen", err)
|
||||
}
|
||||
}
|
||||
|
||||
func TestShutdownCancelledContextReturnsQuickly(t *testing.T) {
|
||||
b, w, done := startTCPClient(t, "ep-shut-cancel")
|
||||
defer func() {
|
||||
_ = w.Close()
|
||||
select {
|
||||
case <-done:
|
||||
case <-time.After(3 * time.Second):
|
||||
}
|
||||
}()
|
||||
writeConnect(t, w, "ep-shut-cancel", 30, 0)
|
||||
readExactPacket(t, w, packets.Connack, 3*time.Second)
|
||||
waitSession(t, b, "ep-shut-cancel")
|
||||
|
||||
ctx, cancel := context.WithCancel(context.Background())
|
||||
cancel()
|
||||
start := time.Now()
|
||||
_ = b.Shutdown(ctx)
|
||||
if time.Since(start) > 500*time.Millisecond {
|
||||
t.Fatalf("cancelled shutdown took %s", time.Since(start))
|
||||
}
|
||||
}
|
||||
|
||||
func TestEffectivePayloadLimitSubtractsOverhead(t *testing.T) {
|
||||
got := EffectivePayloadLimit(200, 0)
|
||||
if got != 200-packetOverheadBudget {
|
||||
|
||||
@@ -141,9 +141,14 @@ type connState struct {
|
||||
downStop chan struct{}
|
||||
downDone chan struct{}
|
||||
downBytes atomic.Int64
|
||||
sentPub atomic.Int64
|
||||
wirePending atomic.Int64 // Publish 入 mochi outbound 后、OnPacketSent 前
|
||||
mu sync.Mutex
|
||||
|
||||
// 带断开的下行帧:只等本帧 OnPacketSent,不用连接级计数。
|
||||
writeWaitCh chan struct{}
|
||||
writeWaitPayload []byte
|
||||
writeWaitPID uint16 // 非 0 时优先按 packet id 匹配
|
||||
|
||||
handshakeTimer *time.Timer
|
||||
}
|
||||
|
||||
@@ -232,28 +237,105 @@ func (b *Broker) Close() error {
|
||||
}
|
||||
|
||||
// Shutdown 向所有连接发 MQTT 5 0x8B 后关闭。完整 HTTP 停机顺序见 L-03。
|
||||
// ctx 未取消时先等下行队列与 wirePending 排空,再 DisconnectClient(此时 outbound 空,
|
||||
// 0x8B 直写套接字),并在截止前等连接拆掉;ctx 已取消则发完即 Close,不等待。
|
||||
func (b *Broker) Shutdown(ctx context.Context) error {
|
||||
if b.closed.Load() {
|
||||
return nil
|
||||
}
|
||||
if ctx == nil {
|
||||
ctx = context.Background()
|
||||
}
|
||||
|
||||
b.connsMu.RLock()
|
||||
states := make([]*connState, 0, len(b.byClient))
|
||||
clients := make([]*mqtt.Client, 0, len(b.byClient))
|
||||
for cl := range b.byClient {
|
||||
for cl, st := range b.byClient {
|
||||
if cl != nil {
|
||||
clients = append(clients, cl)
|
||||
}
|
||||
if st != nil {
|
||||
states = append(states, st)
|
||||
}
|
||||
}
|
||||
b.connsMu.RUnlock()
|
||||
|
||||
for _, st := range states {
|
||||
st.mu.Lock()
|
||||
st.closing = true
|
||||
st.mu.Unlock()
|
||||
}
|
||||
|
||||
alreadyCancelled := false
|
||||
select {
|
||||
case <-ctx.Done():
|
||||
alreadyCancelled = true
|
||||
default:
|
||||
}
|
||||
|
||||
var waitErr error
|
||||
if !alreadyCancelled {
|
||||
if !b.waitConnsQuiet(ctx, states) {
|
||||
waitErr = ctx.Err()
|
||||
}
|
||||
}
|
||||
|
||||
for _, cl := range clients {
|
||||
_ = b.server.DisconnectClient(cl, packets.ErrServerShuttingDown)
|
||||
}
|
||||
if ctx != nil {
|
||||
|
||||
if !alreadyCancelled && waitErr == nil {
|
||||
waitErr = b.waitConnsGone(ctx)
|
||||
}
|
||||
|
||||
closeErr := b.Close()
|
||||
if waitErr != nil {
|
||||
return waitErr
|
||||
}
|
||||
return closeErr
|
||||
}
|
||||
|
||||
func (b *Broker) waitConnsQuiet(ctx context.Context, states []*connState) bool {
|
||||
for {
|
||||
quiet := true
|
||||
for _, st := range states {
|
||||
if st.wirePending.Load() > 0 {
|
||||
quiet = false
|
||||
break
|
||||
}
|
||||
st.mu.Lock()
|
||||
ch := st.downCh
|
||||
st.mu.Unlock()
|
||||
if ch != nil && len(ch) > 0 {
|
||||
quiet = false
|
||||
break
|
||||
}
|
||||
}
|
||||
if quiet {
|
||||
return true
|
||||
}
|
||||
select {
|
||||
case <-ctx.Done():
|
||||
default:
|
||||
return false
|
||||
case <-time.After(2 * time.Millisecond):
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func (b *Broker) waitConnsGone(ctx context.Context) error {
|
||||
for {
|
||||
b.connsMu.RLock()
|
||||
n := len(b.byClient)
|
||||
b.connsMu.RUnlock()
|
||||
if n == 0 {
|
||||
return nil
|
||||
}
|
||||
select {
|
||||
case <-ctx.Done():
|
||||
return ctx.Err()
|
||||
case <-time.After(2 * time.Millisecond):
|
||||
}
|
||||
}
|
||||
return b.Close()
|
||||
}
|
||||
|
||||
// AttachTCP 把裸 TCP/TLS 连接交给 mochi;阻塞到连接结束。
|
||||
|
||||
+115
-12
@@ -1,10 +1,12 @@
|
||||
package broker
|
||||
|
||||
import (
|
||||
"bytes"
|
||||
"context"
|
||||
"time"
|
||||
|
||||
"git.asio.asia/nixevol/NixMsg/internal/app/port"
|
||||
"github.com/mochi-mqtt/server/v2/packets"
|
||||
)
|
||||
|
||||
type downItem struct {
|
||||
@@ -130,7 +132,11 @@ func (st *connState) sendOne(b *Broker, item downItem) {
|
||||
st.mu.Unlock()
|
||||
}
|
||||
topic := downTopic(st.endpointID)
|
||||
before := st.sentPub.Load()
|
||||
var waitCh chan struct{}
|
||||
if item.disconnect != "" {
|
||||
waitCh = st.armWriteWait(item.payload)
|
||||
}
|
||||
st.wirePending.Add(1)
|
||||
var err error
|
||||
for !b.closed.Load() {
|
||||
select {
|
||||
@@ -150,6 +156,14 @@ func (st *connState) sendOne(b *Broker, item downItem) {
|
||||
}
|
||||
break
|
||||
}
|
||||
if err != nil {
|
||||
st.wirePending.Add(-1)
|
||||
st.clearWriteWait(waitCh)
|
||||
} else if waitCh != nil {
|
||||
if pid, ok := st.lookupInflightPID(item.payload); ok {
|
||||
st.setWriteWaitPID(waitCh, pid)
|
||||
}
|
||||
}
|
||||
if large {
|
||||
b.finishLargePublish(st)
|
||||
}
|
||||
@@ -158,23 +172,112 @@ func (st *connState) sendOne(b *Broker, item downItem) {
|
||||
}
|
||||
st.signalSent(item)
|
||||
if err == nil && item.disconnect != "" {
|
||||
st.waitPacketWritten(before)
|
||||
st.waitWriteDone(waitCh)
|
||||
_ = b.Disconnect(context.Background(), st.endpointID, st.connID, item.disconnect)
|
||||
}
|
||||
}
|
||||
|
||||
func (st *connState) waitPacketWritten(before int64) {
|
||||
deadline := time.Now().Add(2 * time.Second)
|
||||
for time.Now().Before(deadline) {
|
||||
if st.sentPub.Load() > before {
|
||||
return
|
||||
}
|
||||
select {
|
||||
case <-st.downStop:
|
||||
return
|
||||
case <-time.After(2 * time.Millisecond):
|
||||
func (st *connState) armWriteWait(payload []byte) chan struct{} {
|
||||
ch := make(chan struct{})
|
||||
st.mu.Lock()
|
||||
st.writeWaitCh = ch
|
||||
st.writeWaitPayload = payload
|
||||
st.writeWaitPID = 0
|
||||
st.mu.Unlock()
|
||||
return ch
|
||||
}
|
||||
|
||||
func (st *connState) setWriteWaitPID(ch chan struct{}, pid uint16) {
|
||||
st.mu.Lock()
|
||||
if st.writeWaitCh == ch {
|
||||
st.writeWaitPID = pid
|
||||
}
|
||||
st.mu.Unlock()
|
||||
}
|
||||
|
||||
func (st *connState) clearWriteWait(ch chan struct{}) {
|
||||
if ch == nil {
|
||||
return
|
||||
}
|
||||
st.mu.Lock()
|
||||
if st.writeWaitCh == ch {
|
||||
st.writeWaitCh = nil
|
||||
st.writeWaitPayload = nil
|
||||
st.writeWaitPID = 0
|
||||
}
|
||||
st.mu.Unlock()
|
||||
}
|
||||
|
||||
func (st *connState) waitWriteDone(ch chan struct{}) {
|
||||
if ch == nil {
|
||||
return
|
||||
}
|
||||
defer st.clearWriteWait(ch)
|
||||
deadline := time.NewTimer(2 * time.Second)
|
||||
defer deadline.Stop()
|
||||
select {
|
||||
case <-ch:
|
||||
case <-st.downStop:
|
||||
case <-deadline.C:
|
||||
}
|
||||
}
|
||||
|
||||
func (st *connState) notePacketSent(pk packets.Packet) {
|
||||
if pk.FixedHeader.Type == packets.Publish {
|
||||
for {
|
||||
cur := st.wirePending.Load()
|
||||
if cur <= 0 {
|
||||
break
|
||||
}
|
||||
if st.wirePending.CompareAndSwap(cur, cur-1) {
|
||||
break
|
||||
}
|
||||
}
|
||||
}
|
||||
st.mu.Lock()
|
||||
ch := st.writeWaitCh
|
||||
pid := st.writeWaitPID
|
||||
want := st.writeWaitPayload
|
||||
st.mu.Unlock()
|
||||
if ch == nil || pk.FixedHeader.Type != packets.Publish {
|
||||
return
|
||||
}
|
||||
match := false
|
||||
if pid != 0 {
|
||||
match = pk.PacketID == pid
|
||||
} else if want != nil {
|
||||
match = bytes.Equal(pk.Payload, want)
|
||||
}
|
||||
if !match {
|
||||
return
|
||||
}
|
||||
st.mu.Lock()
|
||||
if st.writeWaitCh == ch {
|
||||
st.writeWaitCh = nil
|
||||
st.writeWaitPayload = nil
|
||||
st.writeWaitPID = 0
|
||||
}
|
||||
st.mu.Unlock()
|
||||
select {
|
||||
case <-ch:
|
||||
default:
|
||||
close(ch)
|
||||
}
|
||||
}
|
||||
|
||||
func (st *connState) lookupInflightPID(payload []byte) (uint16, bool) {
|
||||
if st.client == nil || st.client.State.Inflight == nil {
|
||||
return 0, false
|
||||
}
|
||||
for _, pk := range st.client.State.Inflight.GetAll(false) {
|
||||
if pk.FixedHeader.Type != packets.Publish {
|
||||
continue
|
||||
}
|
||||
if bytes.Equal(pk.Payload, payload) {
|
||||
return pk.PacketID, pk.PacketID != 0
|
||||
}
|
||||
}
|
||||
return 0, false
|
||||
}
|
||||
|
||||
func (st *connState) signalSent(item downItem) {
|
||||
|
||||
@@ -175,14 +175,11 @@ func (h *nixHook) OnSubscribed(cl *mqtt.Client, pk packets.Packet, reasonCodes [
|
||||
}
|
||||
|
||||
func (h *nixHook) OnPacketSent(cl *mqtt.Client, pk packets.Packet, _ []byte) {
|
||||
if pk.FixedHeader.Type != packets.Publish {
|
||||
return
|
||||
}
|
||||
h.b.connsMu.RLock()
|
||||
st := h.b.byClient[cl]
|
||||
h.b.connsMu.RUnlock()
|
||||
if st != nil {
|
||||
st.sentPub.Add(1)
|
||||
st.notePacketSent(pk)
|
||||
}
|
||||
}
|
||||
|
||||
@@ -254,6 +251,7 @@ func (h *nixHook) OnDisconnect(cl *mqtt.Client, err error, _ bool) {
|
||||
lk.Lock()
|
||||
st.stopDownLoop()
|
||||
lk.Unlock()
|
||||
st.wirePending.Store(0)
|
||||
h.b.releaseAllLarge(st)
|
||||
h.b.cancelHandshakeDeadline(st.endpointID, st.connID)
|
||||
|
||||
|
||||
+9
-22
@@ -36,11 +36,10 @@ type writeJob struct {
|
||||
type Queue struct {
|
||||
db *sql.DB
|
||||
|
||||
ch chan writeJob
|
||||
done chan struct{}
|
||||
closing chan struct{} // Close 时关闭,唤醒持读锁阻塞在发送上的 enqueue
|
||||
closed atomic.Bool
|
||||
sendMu sync.RWMutex
|
||||
ch chan writeJob
|
||||
done chan struct{}
|
||||
closed atomic.Bool
|
||||
sendMu sync.RWMutex
|
||||
|
||||
mu sync.Mutex
|
||||
ready bool
|
||||
@@ -53,16 +52,11 @@ type Queue struct {
|
||||
|
||||
// NewQueue 创建合并写入队列并启动写 goroutine。
|
||||
func NewQueue(db *sql.DB) *Queue {
|
||||
return newQueue(db, queueBuffSize)
|
||||
}
|
||||
|
||||
func newQueue(db *sql.DB, buffSize int) *Queue {
|
||||
q := &Queue{
|
||||
db: db,
|
||||
ch: make(chan writeJob, buffSize),
|
||||
done: make(chan struct{}),
|
||||
closing: make(chan struct{}),
|
||||
ready: true,
|
||||
db: db,
|
||||
ch: make(chan writeJob, queueBuffSize),
|
||||
done: make(chan struct{}),
|
||||
ready: true,
|
||||
}
|
||||
go q.loop()
|
||||
return q
|
||||
@@ -121,15 +115,10 @@ func (q *Queue) enqueue(job writeJob) error {
|
||||
return ErrQueueClosed
|
||||
}
|
||||
q.addPending(1)
|
||||
// 通道满时不得只堵在发送上持有读锁:Close 需要写锁关闭 q.ch。
|
||||
select {
|
||||
case q.ch <- job:
|
||||
q.sendMu.RUnlock()
|
||||
return nil
|
||||
case <-q.closing:
|
||||
q.addPending(-1)
|
||||
q.sendMu.RUnlock()
|
||||
return ErrQueueClosed
|
||||
case <-job.ctx.Done():
|
||||
q.addPending(-1)
|
||||
q.sendMu.RUnlock()
|
||||
@@ -387,13 +376,11 @@ func (q *Queue) Drain(ctx context.Context) error {
|
||||
}
|
||||
|
||||
// Close 关闭队列:不再接受新任务,并等待写 goroutine 处理完已入队任务后退出。
|
||||
// 先关闭 closing 唤醒因通道满而阻塞的发送方并释放读锁,再在无发送者时关闭数据通道,
|
||||
// 避免向已关闭 channel 发送而 panic,也避免与持读锁的 enqueue 死锁。
|
||||
// 在写锁内关闭数据通道,避免并发 Do 向已关闭 channel 发送而 panic。
|
||||
func (q *Queue) Close() error {
|
||||
if q.closed.Swap(true) {
|
||||
return nil
|
||||
}
|
||||
close(q.closing)
|
||||
q.sendMu.Lock()
|
||||
close(q.ch)
|
||||
q.sendMu.Unlock()
|
||||
|
||||
@@ -289,137 +289,3 @@ ON CONFLICT(key) DO UPDATE SET value = excluded.value, updated_at = excluded.upd
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// openSmallQueue 用小缓冲队列替换默认队列,便于测满通道时的 Close/Drain。
|
||||
func openSmallQueue(t *testing.T, buf int) *DB {
|
||||
t.Helper()
|
||||
dir := t.TempDir()
|
||||
db, err := Open(dir, "FULL")
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if err := db.Queue.Close(); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
db.Queue = newQueue(db.Write, buf)
|
||||
return db
|
||||
}
|
||||
|
||||
func TestQueueCloseUnblocksFullChannel(t *testing.T) {
|
||||
t.Parallel()
|
||||
const buf = 4
|
||||
db := openSmallQueue(t, buf)
|
||||
defer func() { _ = db.Close() }()
|
||||
q := db.Queue
|
||||
|
||||
hold := make(chan struct{})
|
||||
blockerStarted := make(chan struct{})
|
||||
blockerErr := make(chan error, 1)
|
||||
go func() {
|
||||
blockerErr <- q.Do(context.Background(), func(tx *sql.Tx) error {
|
||||
close(blockerStarted)
|
||||
<-hold
|
||||
return nil
|
||||
})
|
||||
}()
|
||||
<-blockerStarted
|
||||
|
||||
ctx := context.Background()
|
||||
var fillWG sync.WaitGroup
|
||||
for i := 0; i < buf; i++ {
|
||||
fillWG.Add(1)
|
||||
go func() {
|
||||
defer fillWG.Done()
|
||||
_ = q.Do(ctx, func(tx *sql.Tx) error { return nil })
|
||||
}()
|
||||
}
|
||||
deadline := time.Now().Add(2 * time.Second)
|
||||
for q.Len() < buf+1 && time.Now().Before(deadline) {
|
||||
time.Sleep(2 * time.Millisecond)
|
||||
}
|
||||
if q.Len() < buf+1 {
|
||||
t.Fatalf("channel not full: len=%d", q.Len())
|
||||
}
|
||||
|
||||
blockedErr := make(chan error, 1)
|
||||
go func() {
|
||||
blockedErr <- q.Do(ctx, func(tx *sql.Tx) error { return nil })
|
||||
}()
|
||||
// 等额外 Do 堵在 enqueue(pending 超过通道容量+正在执行的一条)。
|
||||
deadline = time.Now().Add(2 * time.Second)
|
||||
for q.Len() < buf+2 && time.Now().Before(deadline) {
|
||||
time.Sleep(2 * time.Millisecond)
|
||||
}
|
||||
|
||||
closeDone := make(chan error, 1)
|
||||
go func() { closeDone <- q.Close() }()
|
||||
|
||||
select {
|
||||
case err := <-blockedErr:
|
||||
if !errors.Is(err, ErrQueueClosed) {
|
||||
t.Fatalf("blocked Do: %v", err)
|
||||
}
|
||||
case <-time.After(2 * time.Second):
|
||||
t.Fatal("Close did not unblock full-channel enqueue")
|
||||
}
|
||||
|
||||
close(hold)
|
||||
select {
|
||||
case err := <-closeDone:
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
case <-time.After(2 * time.Second):
|
||||
t.Fatal("Close hung after writer released")
|
||||
}
|
||||
<-blockerErr
|
||||
fillWG.Wait()
|
||||
}
|
||||
|
||||
func TestQueueDrainTimeoutWhileWriterBlocked(t *testing.T) {
|
||||
t.Parallel()
|
||||
const buf = 4
|
||||
db := openSmallQueue(t, buf)
|
||||
defer func() { _ = db.Close() }()
|
||||
q := db.Queue
|
||||
|
||||
hold := make(chan struct{})
|
||||
started := make(chan struct{})
|
||||
go func() {
|
||||
_ = q.Do(context.Background(), func(tx *sql.Tx) error {
|
||||
close(started)
|
||||
<-hold
|
||||
return nil
|
||||
})
|
||||
}()
|
||||
<-started
|
||||
|
||||
ctx := context.Background()
|
||||
var wg sync.WaitGroup
|
||||
for i := 0; i < buf; i++ {
|
||||
wg.Add(1)
|
||||
go func() {
|
||||
defer wg.Done()
|
||||
_ = q.Do(ctx, func(tx *sql.Tx) error { return nil })
|
||||
}()
|
||||
}
|
||||
deadline := time.Now().Add(2 * time.Second)
|
||||
for q.Len() < buf+1 && time.Now().Before(deadline) {
|
||||
time.Sleep(2 * time.Millisecond)
|
||||
}
|
||||
|
||||
drainCtx, cancel := context.WithTimeout(context.Background(), 80*time.Millisecond)
|
||||
defer cancel()
|
||||
start := time.Now()
|
||||
err := q.Drain(drainCtx)
|
||||
elapsed := time.Since(start)
|
||||
if !errors.Is(err, context.DeadlineExceeded) {
|
||||
t.Fatalf("Drain err=%v want deadline", err)
|
||||
}
|
||||
if elapsed > 500*time.Millisecond {
|
||||
t.Fatalf("Drain took %s, should return on timeout", elapsed)
|
||||
}
|
||||
|
||||
close(hold)
|
||||
wg.Wait()
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user