Compare commits
1
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
a14ca0d08d |
+3
-1
@@ -335,7 +335,9 @@ func runServe(ctx context.Context, cfg config.Config) error {
|
|||||||
drainCancel()
|
drainCancel()
|
||||||
|
|
||||||
shutCtx, shutCancel := context.WithTimeout(context.Background(), 5*time.Second)
|
shutCtx, shutCancel := context.WithTimeout(context.Background(), 5*time.Second)
|
||||||
_ = brk.Shutdown(shutCtx)
|
if shutErr := brk.Shutdown(shutCtx); shutErr != nil && !errors.Is(shutErr, context.DeadlineExceeded) && !errors.Is(shutErr, context.Canceled) {
|
||||||
|
slog.Error("broker shutdown", "err", shutErr)
|
||||||
|
}
|
||||||
shutCancel()
|
shutCancel()
|
||||||
|
|
||||||
secondDrain := drainBudget - time.Since(drainStart)
|
secondDrain := drainBudget - time.Since(drainStart)
|
||||||
|
|||||||
+7
-7
@@ -1719,12 +1719,12 @@ issue #3 未关闭,`feat/fix-3-downlink-deadlock` 未合入 `main`。下面是
|
|||||||
- 备选方案:为每个未测子项补验收用例(本波不做,避免为变绿放松断言)。
|
- 备选方案:为每个未测子项补验收用例(本波不做,避免为变绿放松断言)。
|
||||||
- 影响:汇总改为通过 19、部分通过 4(F03/F08/F21/F22)、失败 0。F19 仍引用仓库内 SDK 清单、本波不重跑。
|
- 影响:汇总改为通过 19、部分通过 4(F03/F08/F21/F22)、失败 0。F19 仍引用仓库内 SDK 清单、本波不重跑。
|
||||||
|
|
||||||
### 复审修复 R3-08
|
### 复审修复 R3-02
|
||||||
|
|
||||||
1. **后台加人审计按实际插入数,全跳过不记 ok**
|
1. **积压时 fatal/logout 与停机 0x8B 须等本帧写出**
|
||||||
- 日期:2026-09-30
|
- 日期:2026-09-30
|
||||||
- 原条款:Gitea #72;`AdminAddMembers` 对已是成员与请求内重复编号静默跳过;审计用 `len(member_ids)-len(failed)` 当成功数。
|
- 原条款:Gitea #66;B-04 / B-08。
|
||||||
- 实际做法:`handleGroupAddMembers` 用加人前后 `group_members` 行数差得到 `added`;审计 `result` 用 `added` 与 `failed`(全跳过且无失败记 `noop`,不记 `ok`);响应增加 `added`,`failed` 仍只含真正失败项。前端按 `added` 提示,已是成员不改成错误码。
|
- 实际做法:带断开的下行帧用本帧 `OnPacketSent` 完成信号(优先 packet id,否则按载荷匹配),不再用连接级 `sentPub` 总数。`Shutdown` 在 ctx 未取消时先等下行队列与 `wirePending` 排空,再 `DisconnectClient` 发 `0x8B` 并在截止前等连接拆掉;ctx 已取消则发完即 `Close`。`serve` 仍给 5 秒预算并记录非超时错误。未合 `feat/fix-3-downlink-deadlock`。
|
||||||
- 原因:全是已有成员时旧逻辑审计成 ok、界面提示已加人,实际插入 0 行。
|
- 原因:前面 PUBLISH 的 `OnPacketSent` 会让总数等待提前返回;`Shutdown` 对 ctx 非阻塞 select 使 5 秒预算用不上,有 outbound 积压时 `0x8B` 只进 outbuf 随 `Stop` 丢掉。
|
||||||
- 备选方案:把已是成员写入 `failed`(否决,会改变客户端错误语义);扩展 `group.AddResult` 返回插入列表(可后续做,本波不改身份线接口)。
|
- 备选方案:恢复固定 `Sleep`(否决);改 `PublishDown` 签名(否决)。
|
||||||
- 影响:管理 API 加人成功体多 `added` 字段;契约文档示例仍写 `{"failed":[]}`,以本偏差为准。
|
- 影响:队列/outbound 有积压时 fatal、logout 先到客户端再断开;停机在预算内尽量发出 `0x8B`,超时返回 ctx 错误而非空等。
|
||||||
|
|||||||
@@ -316,13 +316,6 @@ func (h *Handler) handleGroupAddMembers(w http.ResponseWriter, r *http.Request)
|
|||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
before, err := h.groupMemberCount(r.Context(), id)
|
|
||||||
if err != nil {
|
|
||||||
h.auditP(p, "group_add_members", id, "error", ip)
|
|
||||||
httpx.WriteError(w, http.StatusInternalServerError, "internal", "内部错误")
|
|
||||||
return
|
|
||||||
}
|
|
||||||
|
|
||||||
res, err := h.groups.AdminAddMembers(r.Context(), id, req.MemberIDs)
|
res, err := h.groups.AdminAddMembers(r.Context(), id, req.MemberIDs)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
h.writeGroupErr(w, p, "group_add_members", id, ip, err)
|
h.writeGroupErr(w, p, "group_add_members", id, ip, err)
|
||||||
@@ -332,29 +325,15 @@ func (h *Handler) handleGroupAddMembers(w http.ResponseWriter, r *http.Request)
|
|||||||
if failed == nil {
|
if failed == nil {
|
||||||
failed = []group.MemberFail{}
|
failed = []group.MemberFail{}
|
||||||
}
|
}
|
||||||
|
okN := len(req.MemberIDs) - len(failed)
|
||||||
after, err := h.groupMemberCount(r.Context(), id)
|
if okN < 0 {
|
||||||
if err != nil {
|
okN = 0
|
||||||
h.auditP(p, "group_add_members", id, "error", ip)
|
|
||||||
httpx.WriteError(w, http.StatusInternalServerError, "internal", "内部错误")
|
|
||||||
return
|
|
||||||
}
|
}
|
||||||
added := after - before
|
h.auditPD(p, "group_add_members", id, batchAuditResult(okN, len(failed)), ip, map[string]any{
|
||||||
if added < 0 {
|
|
||||||
added = 0
|
|
||||||
}
|
|
||||||
|
|
||||||
// 已是成员/请求内重复编号会静默跳过,不算失败;审计用实际插入数,避免全跳过写成 ok。
|
|
||||||
result := batchAuditResult(added, len(failed))
|
|
||||||
if added == 0 && len(failed) == 0 {
|
|
||||||
result = "noop"
|
|
||||||
}
|
|
||||||
h.auditPD(p, "group_add_members", id, result, ip, map[string]any{
|
|
||||||
"members": req.MemberIDs,
|
"members": req.MemberIDs,
|
||||||
"failed": failed,
|
"failed": failed,
|
||||||
"added": added,
|
|
||||||
})
|
})
|
||||||
httpx.WriteOK(w, map[string]any{"failed": failed, "added": added})
|
httpx.WriteOK(w, map[string]any{"failed": failed})
|
||||||
}
|
}
|
||||||
|
|
||||||
func (h *Handler) handleGroupRemoveMember(w http.ResponseWriter, r *http.Request) {
|
func (h *Handler) handleGroupRemoveMember(w http.ResponseWriter, r *http.Request) {
|
||||||
@@ -434,13 +413,6 @@ func (h *Handler) groupOwner(ctx context.Context, groupID string) (string, error
|
|||||||
return owner, err
|
return owner, err
|
||||||
}
|
}
|
||||||
|
|
||||||
func (h *Handler) groupMemberCount(ctx context.Context, groupID string) (int, error) {
|
|
||||||
var n int
|
|
||||||
err := h.db.Read.QueryRowContext(ctx,
|
|
||||||
`SELECT COUNT(*) FROM group_members WHERE group_id = ?`, groupID).Scan(&n)
|
|
||||||
return n, err
|
|
||||||
}
|
|
||||||
|
|
||||||
func (h *Handler) groupSummary(ctx context.Context, groupID string) (map[string]any, error) {
|
func (h *Handler) groupSummary(ctx context.Context, groupID string) (map[string]any, error) {
|
||||||
var name, owner string
|
var name, owner string
|
||||||
var created int64
|
var created int64
|
||||||
|
|||||||
@@ -262,7 +262,6 @@ func TestH02BatchPartialImportAndGroups(t *testing.T) {
|
|||||||
insertEndpoint(t, db, "keep-1", "admin", true, false)
|
insertEndpoint(t, db, "keep-1", "admin", true, false)
|
||||||
insertEndpoint(t, db, "alice", "admin", true, false)
|
insertEndpoint(t, db, "alice", "admin", true, false)
|
||||||
insertEndpoint(t, db, "bob", "admin", true, false)
|
insertEndpoint(t, db, "bob", "admin", true, false)
|
||||||
insertEndpoint(t, db, "carol", "admin", true, false)
|
|
||||||
|
|
||||||
res := doReq(t, client, http.MethodPost, srv.URL+"/api/admin/endpoints/batch",
|
res := doReq(t, client, http.MethodPost, srv.URL+"/api/admin/endpoints/batch",
|
||||||
`{"ids":["keep-1","missing-ep"],"action":"disable"}`,
|
`{"ids":["keep-1","missing-ep"],"action":"disable"}`,
|
||||||
@@ -305,24 +304,11 @@ func TestH02BatchPartialImportAndGroups(t *testing.T) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
res = doReq(t, client, http.MethodPost, srv.URL+"/api/admin/groups/"+created.ID+"/members",
|
res = doReq(t, client, http.MethodPost, srv.URL+"/api/admin/groups/"+created.ID+"/members",
|
||||||
`{"member_ids":["carol","ghost-ep"]}`, csrf())
|
`{"member_ids":["keep-1","ghost-ep"]}`, csrf())
|
||||||
env = decodeEnv(t, res)
|
env = decodeEnv(t, res)
|
||||||
if res.StatusCode != http.StatusOK || !env.OK {
|
if res.StatusCode != http.StatusOK || !env.OK {
|
||||||
t.Fatalf("add members: %d %+v", res.StatusCode, env)
|
t.Fatalf("add members: %d %+v", res.StatusCode, env)
|
||||||
}
|
}
|
||||||
var addBody struct {
|
|
||||||
Failed []any `json:"failed"`
|
|
||||||
Added int `json:"added"`
|
|
||||||
}
|
|
||||||
if err := json.Unmarshal(env.Data, &addBody); err != nil {
|
|
||||||
t.Fatal(err)
|
|
||||||
}
|
|
||||||
if addBody.Added != 1 {
|
|
||||||
t.Fatalf("add response added=%d want 1", addBody.Added)
|
|
||||||
}
|
|
||||||
if len(addBody.Failed) != 1 {
|
|
||||||
t.Fatalf("add response failed=%v want 1", addBody.Failed)
|
|
||||||
}
|
|
||||||
|
|
||||||
res = doReq(t, client, http.MethodPost, srv.URL+"/api/admin/groups/"+created.ID+"/transfer",
|
res = doReq(t, client, http.MethodPost, srv.URL+"/api/admin/groups/"+created.ID+"/transfer",
|
||||||
`{"endpoint_id":"bob"}`, csrf())
|
`{"endpoint_id":"bob"}`, csrf())
|
||||||
@@ -360,8 +346,8 @@ func TestH02BatchPartialImportAndGroups(t *testing.T) {
|
|||||||
if ad == nil {
|
if ad == nil {
|
||||||
t.Fatalf("add members missing detail: %v", add)
|
t.Fatalf("add members missing detail: %v", add)
|
||||||
}
|
}
|
||||||
if add["result"] != "partial" {
|
if add["result"] != "partial" && add["result"] != "failed" && add["result"] != "ok" {
|
||||||
t.Fatalf("add members result=%v want partial", add["result"])
|
t.Fatalf("add members result=%v", add["result"])
|
||||||
}
|
}
|
||||||
if _, ok := ad["members"]; !ok {
|
if _, ok := ad["members"]; !ok {
|
||||||
t.Fatalf("add members missing members: %v", ad)
|
t.Fatalf("add members missing members: %v", ad)
|
||||||
@@ -369,9 +355,6 @@ func TestH02BatchPartialImportAndGroups(t *testing.T) {
|
|||||||
if _, ok := ad["failed"]; !ok {
|
if _, ok := ad["failed"]; !ok {
|
||||||
t.Fatalf("add members missing failed: %v", ad)
|
t.Fatalf("add members missing failed: %v", ad)
|
||||||
}
|
}
|
||||||
if ad["added"] != float64(1) {
|
|
||||||
t.Fatalf("add members added=%v want 1", ad["added"])
|
|
||||||
}
|
|
||||||
|
|
||||||
tr := lastAuditByAction(t, recs, "group_transfer")
|
tr := lastAuditByAction(t, recs, "group_transfer")
|
||||||
td, _ := tr["detail"].(map[string]any)
|
td, _ := tr["detail"].(map[string]any)
|
||||||
@@ -381,70 +364,3 @@ func TestH02BatchPartialImportAndGroups(t *testing.T) {
|
|||||||
|
|
||||||
assertNoSecrets(t, auditBuf.String(), "csv-pass-secret-1", "csv-pass-secret-2", testPassword)
|
assertNoSecrets(t, auditBuf.String(), "csv-pass-secret-1", "csv-pass-secret-2", testPassword)
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestH02AddMembersAllSkippedAuditNotOK(t *testing.T) {
|
|
||||||
_, auditBuf, db, srv, client := setupH02(t)
|
|
||||||
login(t, client, srv.URL)
|
|
||||||
insertEndpoint(t, db, "alice", "admin", true, false)
|
|
||||||
insertEndpoint(t, db, "bob", "admin", true, false)
|
|
||||||
|
|
||||||
res := doReq(t, client, http.MethodPost, srv.URL+"/api/admin/groups",
|
|
||||||
`{"name":"一组","owner_id":"alice","member_ids":["bob"]}`, csrf())
|
|
||||||
env := decodeEnv(t, res)
|
|
||||||
if res.StatusCode != http.StatusOK || !env.OK {
|
|
||||||
t.Fatalf("group create: %d %+v", res.StatusCode, env)
|
|
||||||
}
|
|
||||||
var created struct {
|
|
||||||
ID string `json:"id"`
|
|
||||||
}
|
|
||||||
if err := json.Unmarshal(env.Data, &created); err != nil {
|
|
||||||
t.Fatal(err)
|
|
||||||
}
|
|
||||||
|
|
||||||
auditBuf.Reset()
|
|
||||||
var before int
|
|
||||||
if err := db.Read.QueryRow(`SELECT COUNT(*) FROM group_members WHERE group_id = ?`, created.ID).Scan(&before); err != nil {
|
|
||||||
t.Fatal(err)
|
|
||||||
}
|
|
||||||
|
|
||||||
res = doReq(t, client, http.MethodPost, srv.URL+"/api/admin/groups/"+created.ID+"/members",
|
|
||||||
`{"member_ids":["bob","bob","alice"]}`, csrf())
|
|
||||||
env = decodeEnv(t, res)
|
|
||||||
if res.StatusCode != http.StatusOK || !env.OK {
|
|
||||||
t.Fatalf("add members: %d %+v", res.StatusCode, env)
|
|
||||||
}
|
|
||||||
var body struct {
|
|
||||||
Failed []any `json:"failed"`
|
|
||||||
Added int `json:"added"`
|
|
||||||
}
|
|
||||||
if err := json.Unmarshal(env.Data, &body); err != nil {
|
|
||||||
t.Fatal(err)
|
|
||||||
}
|
|
||||||
if len(body.Failed) != 0 {
|
|
||||||
t.Fatalf("failed=%v want empty (already members are not errors)", body.Failed)
|
|
||||||
}
|
|
||||||
if body.Added != 0 {
|
|
||||||
t.Fatalf("added=%d want 0", body.Added)
|
|
||||||
}
|
|
||||||
|
|
||||||
var after int
|
|
||||||
if err := db.Read.QueryRow(`SELECT COUNT(*) FROM group_members WHERE group_id = ?`, created.ID).Scan(&after); err != nil {
|
|
||||||
t.Fatal(err)
|
|
||||||
}
|
|
||||||
if after != before {
|
|
||||||
t.Fatalf("member rows before=%d after=%d want unchanged", before, after)
|
|
||||||
}
|
|
||||||
|
|
||||||
recs := parseSlogJSON(t, auditBuf)
|
|
||||||
add := lastAuditByAction(t, recs, "group_add_members")
|
|
||||||
if add["result"] == "ok" {
|
|
||||||
t.Fatalf("audit result must not be ok when all skipped: %v", add)
|
|
||||||
}
|
|
||||||
ad, _ := add["detail"].(map[string]any)
|
|
||||||
if ad == nil {
|
|
||||||
t.Fatalf("missing detail: %v", add)
|
|
||||||
}
|
|
||||||
if ad["added"] != float64(0) {
|
|
||||||
t.Fatalf("detail.added=%v want 0", ad["added"])
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|||||||
@@ -87,6 +87,50 @@ func TestPublishThenDisconnectWritesThenCloses(t *testing.T) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func TestPublishThenDisconnectAfterQueuedFrame(t *testing.T) {
|
||||||
|
b, w, done := startTCPClient(t, "ep-ptd-q")
|
||||||
|
defer func() { _ = b.Close() }()
|
||||||
|
defer func() {
|
||||||
|
_ = w.Close()
|
||||||
|
select {
|
||||||
|
case <-done:
|
||||||
|
case <-time.After(3 * time.Second):
|
||||||
|
}
|
||||||
|
}()
|
||||||
|
writeConnect(t, w, "ep-ptd-q", 30, 0)
|
||||||
|
readExactPacket(t, w, packets.Connack, 3*time.Second)
|
||||||
|
writeSubscribe(t, w, downTopic("ep-ptd-q"))
|
||||||
|
readExactPacket(t, w, packets.Suback, 3*time.Second)
|
||||||
|
waitSession(t, b, "ep-ptd-q")
|
||||||
|
|
||||||
|
first := []byte(`{"v":1,"type":"msg","id":"queued-ahead"}`)
|
||||||
|
fatal := []byte(`{"v":1,"type":"fatal","reason":"disabled"}`)
|
||||||
|
if err := b.PublishDown(context.Background(), "ep-ptd-q", "", first, port.PublishOpts{QoS: 1}); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if err := b.PublishThenDisconnect(context.Background(), "ep-ptd-q", "", fatal, 1, port.DisconnectFatal); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
|
||||||
|
gotFirst := readDownPayload(t, w, 3*time.Second)
|
||||||
|
if !bytes.Equal(gotFirst, first) {
|
||||||
|
t.Fatalf("first got %s", gotFirst)
|
||||||
|
}
|
||||||
|
gotFatal := readDownPayload(t, w, 3*time.Second)
|
||||||
|
if !bytes.Equal(gotFatal, fatal) {
|
||||||
|
t.Fatalf("fatal got %s want %s (disconnected before fatal frame)", gotFatal, fatal)
|
||||||
|
}
|
||||||
|
_ = w.SetReadDeadline(time.Now().Add(3 * time.Second))
|
||||||
|
buf := make([]byte, 64)
|
||||||
|
n, err := io.ReadAtLeast(w, buf, 2)
|
||||||
|
if err != nil && n == 0 {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
if n > 0 && buf[0]>>4 == packets.Disconnect {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
func TestShutdownUsesServerShuttingDown(t *testing.T) {
|
func TestShutdownUsesServerShuttingDown(t *testing.T) {
|
||||||
b, w, done := startTCPClient(t, "ep-shut")
|
b, w, done := startTCPClient(t, "ep-shut")
|
||||||
defer func() {
|
defer func() {
|
||||||
@@ -116,6 +160,120 @@ func TestShutdownUsesServerShuttingDown(t *testing.T) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func TestShutdownWithBacklogDeliversServerShuttingDown(t *testing.T) {
|
||||||
|
b, w, done := startTCPClient(t, "ep-shut-bl")
|
||||||
|
defer func() {
|
||||||
|
_ = w.Close()
|
||||||
|
select {
|
||||||
|
case <-done:
|
||||||
|
case <-time.After(3 * time.Second):
|
||||||
|
}
|
||||||
|
}()
|
||||||
|
writeConnect(t, w, "ep-shut-bl", 30, 0)
|
||||||
|
readExactPacket(t, w, packets.Connack, 3*time.Second)
|
||||||
|
writeSubscribe(t, w, downTopic("ep-shut-bl"))
|
||||||
|
readExactPacket(t, w, packets.Suback, 3*time.Second)
|
||||||
|
waitSession(t, b, "ep-shut-bl")
|
||||||
|
|
||||||
|
payload := bytes.Repeat([]byte("b"), 1024)
|
||||||
|
for i := 0; i < 8; i++ {
|
||||||
|
if err := b.PublishDown(context.Background(), "ep-shut-bl", "", payload, port.PublishOpts{QoS: 1}); err != nil {
|
||||||
|
t.Fatalf("publish %d: %v", i, err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
saw8B := make(chan bool, 1)
|
||||||
|
go func() {
|
||||||
|
deadline := time.Now().Add(3 * time.Second)
|
||||||
|
for time.Now().Before(deadline) {
|
||||||
|
_ = w.SetReadDeadline(time.Now().Add(200 * time.Millisecond))
|
||||||
|
hdr := make([]byte, 1)
|
||||||
|
if _, err := io.ReadFull(w, hdr); err != nil {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
rem, err := readRemainingLengthConn(w)
|
||||||
|
if err != nil {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
body := make([]byte, rem)
|
||||||
|
if _, err := io.ReadFull(w, body); err != nil {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
switch hdr[0] >> 4 {
|
||||||
|
case packets.Publish:
|
||||||
|
qos := (hdr[0] >> 1) & 0x3
|
||||||
|
if qos > 0 {
|
||||||
|
pk := new(packets.Packet)
|
||||||
|
pk.ProtocolVersion = 5
|
||||||
|
pk.FixedHeader = packets.FixedHeader{Type: packets.Publish, Remaining: rem, Qos: qos}
|
||||||
|
if decErr := pk.PublishDecode(body); decErr == nil {
|
||||||
|
ack := packets.Packet{
|
||||||
|
FixedHeader: packets.FixedHeader{Type: packets.Puback},
|
||||||
|
ProtocolVersion: 5,
|
||||||
|
PacketID: pk.PacketID,
|
||||||
|
}
|
||||||
|
var ab bytes.Buffer
|
||||||
|
_ = ack.PubackEncode(&ab)
|
||||||
|
_, _ = w.Write(ab.Bytes())
|
||||||
|
}
|
||||||
|
}
|
||||||
|
case packets.Disconnect:
|
||||||
|
if rem >= 1 && body[0] == packets.ErrServerShuttingDown.Code {
|
||||||
|
saw8B <- true
|
||||||
|
return
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
saw8B <- false
|
||||||
|
}()
|
||||||
|
time.Sleep(20 * time.Millisecond)
|
||||||
|
|
||||||
|
ctx, cancel := context.WithTimeout(context.Background(), 3*time.Second)
|
||||||
|
defer cancel()
|
||||||
|
err := b.Shutdown(ctx)
|
||||||
|
|
||||||
|
got := false
|
||||||
|
select {
|
||||||
|
case got = <-saw8B:
|
||||||
|
case <-time.After(4 * time.Second):
|
||||||
|
t.Fatal("reader hung")
|
||||||
|
}
|
||||||
|
if got {
|
||||||
|
if err != nil && !errors.Is(err, context.DeadlineExceeded) {
|
||||||
|
t.Fatalf("shutdown after 0x8B: %v", err)
|
||||||
|
}
|
||||||
|
return
|
||||||
|
}
|
||||||
|
if err == nil {
|
||||||
|
t.Fatal("expected 0x8B or shutdown deadline error, got neither")
|
||||||
|
}
|
||||||
|
if !errors.Is(err, context.DeadlineExceeded) && !errors.Is(err, context.Canceled) {
|
||||||
|
t.Fatalf("shutdown err=%v want deadline/cancel when 0x8B not seen", err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestShutdownCancelledContextReturnsQuickly(t *testing.T) {
|
||||||
|
b, w, done := startTCPClient(t, "ep-shut-cancel")
|
||||||
|
defer func() {
|
||||||
|
_ = w.Close()
|
||||||
|
select {
|
||||||
|
case <-done:
|
||||||
|
case <-time.After(3 * time.Second):
|
||||||
|
}
|
||||||
|
}()
|
||||||
|
writeConnect(t, w, "ep-shut-cancel", 30, 0)
|
||||||
|
readExactPacket(t, w, packets.Connack, 3*time.Second)
|
||||||
|
waitSession(t, b, "ep-shut-cancel")
|
||||||
|
|
||||||
|
ctx, cancel := context.WithCancel(context.Background())
|
||||||
|
cancel()
|
||||||
|
start := time.Now()
|
||||||
|
_ = b.Shutdown(ctx)
|
||||||
|
if time.Since(start) > 500*time.Millisecond {
|
||||||
|
t.Fatalf("cancelled shutdown took %s", time.Since(start))
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
func TestEffectivePayloadLimitSubtractsOverhead(t *testing.T) {
|
func TestEffectivePayloadLimitSubtractsOverhead(t *testing.T) {
|
||||||
got := EffectivePayloadLimit(200, 0)
|
got := EffectivePayloadLimit(200, 0)
|
||||||
if got != 200-packetOverheadBudget {
|
if got != 200-packetOverheadBudget {
|
||||||
|
|||||||
@@ -141,9 +141,14 @@ type connState struct {
|
|||||||
downStop chan struct{}
|
downStop chan struct{}
|
||||||
downDone chan struct{}
|
downDone chan struct{}
|
||||||
downBytes atomic.Int64
|
downBytes atomic.Int64
|
||||||
sentPub atomic.Int64
|
wirePending atomic.Int64 // Publish 入 mochi outbound 后、OnPacketSent 前
|
||||||
mu sync.Mutex
|
mu sync.Mutex
|
||||||
|
|
||||||
|
// 带断开的下行帧:只等本帧 OnPacketSent,不用连接级计数。
|
||||||
|
writeWaitCh chan struct{}
|
||||||
|
writeWaitPayload []byte
|
||||||
|
writeWaitPID uint16 // 非 0 时优先按 packet id 匹配
|
||||||
|
|
||||||
handshakeTimer *time.Timer
|
handshakeTimer *time.Timer
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -232,28 +237,105 @@ func (b *Broker) Close() error {
|
|||||||
}
|
}
|
||||||
|
|
||||||
// Shutdown 向所有连接发 MQTT 5 0x8B 后关闭。完整 HTTP 停机顺序见 L-03。
|
// Shutdown 向所有连接发 MQTT 5 0x8B 后关闭。完整 HTTP 停机顺序见 L-03。
|
||||||
|
// ctx 未取消时先等下行队列与 wirePending 排空,再 DisconnectClient(此时 outbound 空,
|
||||||
|
// 0x8B 直写套接字),并在截止前等连接拆掉;ctx 已取消则发完即 Close,不等待。
|
||||||
func (b *Broker) Shutdown(ctx context.Context) error {
|
func (b *Broker) Shutdown(ctx context.Context) error {
|
||||||
if b.closed.Load() {
|
if b.closed.Load() {
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
if ctx == nil {
|
||||||
|
ctx = context.Background()
|
||||||
|
}
|
||||||
|
|
||||||
b.connsMu.RLock()
|
b.connsMu.RLock()
|
||||||
|
states := make([]*connState, 0, len(b.byClient))
|
||||||
clients := make([]*mqtt.Client, 0, len(b.byClient))
|
clients := make([]*mqtt.Client, 0, len(b.byClient))
|
||||||
for cl := range b.byClient {
|
for cl, st := range b.byClient {
|
||||||
if cl != nil {
|
if cl != nil {
|
||||||
clients = append(clients, cl)
|
clients = append(clients, cl)
|
||||||
}
|
}
|
||||||
|
if st != nil {
|
||||||
|
states = append(states, st)
|
||||||
|
}
|
||||||
}
|
}
|
||||||
b.connsMu.RUnlock()
|
b.connsMu.RUnlock()
|
||||||
|
|
||||||
|
for _, st := range states {
|
||||||
|
st.mu.Lock()
|
||||||
|
st.closing = true
|
||||||
|
st.mu.Unlock()
|
||||||
|
}
|
||||||
|
|
||||||
|
alreadyCancelled := false
|
||||||
|
select {
|
||||||
|
case <-ctx.Done():
|
||||||
|
alreadyCancelled = true
|
||||||
|
default:
|
||||||
|
}
|
||||||
|
|
||||||
|
var waitErr error
|
||||||
|
if !alreadyCancelled {
|
||||||
|
if !b.waitConnsQuiet(ctx, states) {
|
||||||
|
waitErr = ctx.Err()
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
for _, cl := range clients {
|
for _, cl := range clients {
|
||||||
_ = b.server.DisconnectClient(cl, packets.ErrServerShuttingDown)
|
_ = b.server.DisconnectClient(cl, packets.ErrServerShuttingDown)
|
||||||
}
|
}
|
||||||
if ctx != nil {
|
|
||||||
|
if !alreadyCancelled && waitErr == nil {
|
||||||
|
waitErr = b.waitConnsGone(ctx)
|
||||||
|
}
|
||||||
|
|
||||||
|
closeErr := b.Close()
|
||||||
|
if waitErr != nil {
|
||||||
|
return waitErr
|
||||||
|
}
|
||||||
|
return closeErr
|
||||||
|
}
|
||||||
|
|
||||||
|
func (b *Broker) waitConnsQuiet(ctx context.Context, states []*connState) bool {
|
||||||
|
for {
|
||||||
|
quiet := true
|
||||||
|
for _, st := range states {
|
||||||
|
if st.wirePending.Load() > 0 {
|
||||||
|
quiet = false
|
||||||
|
break
|
||||||
|
}
|
||||||
|
st.mu.Lock()
|
||||||
|
ch := st.downCh
|
||||||
|
st.mu.Unlock()
|
||||||
|
if ch != nil && len(ch) > 0 {
|
||||||
|
quiet = false
|
||||||
|
break
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if quiet {
|
||||||
|
return true
|
||||||
|
}
|
||||||
select {
|
select {
|
||||||
case <-ctx.Done():
|
case <-ctx.Done():
|
||||||
default:
|
return false
|
||||||
|
case <-time.After(2 * time.Millisecond):
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func (b *Broker) waitConnsGone(ctx context.Context) error {
|
||||||
|
for {
|
||||||
|
b.connsMu.RLock()
|
||||||
|
n := len(b.byClient)
|
||||||
|
b.connsMu.RUnlock()
|
||||||
|
if n == 0 {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
select {
|
||||||
|
case <-ctx.Done():
|
||||||
|
return ctx.Err()
|
||||||
|
case <-time.After(2 * time.Millisecond):
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
return b.Close()
|
|
||||||
}
|
}
|
||||||
|
|
||||||
// AttachTCP 把裸 TCP/TLS 连接交给 mochi;阻塞到连接结束。
|
// AttachTCP 把裸 TCP/TLS 连接交给 mochi;阻塞到连接结束。
|
||||||
|
|||||||
+115
-12
@@ -1,10 +1,12 @@
|
|||||||
package broker
|
package broker
|
||||||
|
|
||||||
import (
|
import (
|
||||||
|
"bytes"
|
||||||
"context"
|
"context"
|
||||||
"time"
|
"time"
|
||||||
|
|
||||||
"git.asio.asia/nixevol/NixMsg/internal/app/port"
|
"git.asio.asia/nixevol/NixMsg/internal/app/port"
|
||||||
|
"github.com/mochi-mqtt/server/v2/packets"
|
||||||
)
|
)
|
||||||
|
|
||||||
type downItem struct {
|
type downItem struct {
|
||||||
@@ -130,7 +132,11 @@ func (st *connState) sendOne(b *Broker, item downItem) {
|
|||||||
st.mu.Unlock()
|
st.mu.Unlock()
|
||||||
}
|
}
|
||||||
topic := downTopic(st.endpointID)
|
topic := downTopic(st.endpointID)
|
||||||
before := st.sentPub.Load()
|
var waitCh chan struct{}
|
||||||
|
if item.disconnect != "" {
|
||||||
|
waitCh = st.armWriteWait(item.payload)
|
||||||
|
}
|
||||||
|
st.wirePending.Add(1)
|
||||||
var err error
|
var err error
|
||||||
for !b.closed.Load() {
|
for !b.closed.Load() {
|
||||||
select {
|
select {
|
||||||
@@ -150,6 +156,14 @@ func (st *connState) sendOne(b *Broker, item downItem) {
|
|||||||
}
|
}
|
||||||
break
|
break
|
||||||
}
|
}
|
||||||
|
if err != nil {
|
||||||
|
st.wirePending.Add(-1)
|
||||||
|
st.clearWriteWait(waitCh)
|
||||||
|
} else if waitCh != nil {
|
||||||
|
if pid, ok := st.lookupInflightPID(item.payload); ok {
|
||||||
|
st.setWriteWaitPID(waitCh, pid)
|
||||||
|
}
|
||||||
|
}
|
||||||
if large {
|
if large {
|
||||||
b.finishLargePublish(st)
|
b.finishLargePublish(st)
|
||||||
}
|
}
|
||||||
@@ -158,23 +172,112 @@ func (st *connState) sendOne(b *Broker, item downItem) {
|
|||||||
}
|
}
|
||||||
st.signalSent(item)
|
st.signalSent(item)
|
||||||
if err == nil && item.disconnect != "" {
|
if err == nil && item.disconnect != "" {
|
||||||
st.waitPacketWritten(before)
|
st.waitWriteDone(waitCh)
|
||||||
_ = b.Disconnect(context.Background(), st.endpointID, st.connID, item.disconnect)
|
_ = b.Disconnect(context.Background(), st.endpointID, st.connID, item.disconnect)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
func (st *connState) waitPacketWritten(before int64) {
|
func (st *connState) armWriteWait(payload []byte) chan struct{} {
|
||||||
deadline := time.Now().Add(2 * time.Second)
|
ch := make(chan struct{})
|
||||||
for time.Now().Before(deadline) {
|
st.mu.Lock()
|
||||||
if st.sentPub.Load() > before {
|
st.writeWaitCh = ch
|
||||||
return
|
st.writeWaitPayload = payload
|
||||||
}
|
st.writeWaitPID = 0
|
||||||
select {
|
st.mu.Unlock()
|
||||||
case <-st.downStop:
|
return ch
|
||||||
return
|
}
|
||||||
case <-time.After(2 * time.Millisecond):
|
|
||||||
|
func (st *connState) setWriteWaitPID(ch chan struct{}, pid uint16) {
|
||||||
|
st.mu.Lock()
|
||||||
|
if st.writeWaitCh == ch {
|
||||||
|
st.writeWaitPID = pid
|
||||||
|
}
|
||||||
|
st.mu.Unlock()
|
||||||
|
}
|
||||||
|
|
||||||
|
func (st *connState) clearWriteWait(ch chan struct{}) {
|
||||||
|
if ch == nil {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
st.mu.Lock()
|
||||||
|
if st.writeWaitCh == ch {
|
||||||
|
st.writeWaitCh = nil
|
||||||
|
st.writeWaitPayload = nil
|
||||||
|
st.writeWaitPID = 0
|
||||||
|
}
|
||||||
|
st.mu.Unlock()
|
||||||
|
}
|
||||||
|
|
||||||
|
func (st *connState) waitWriteDone(ch chan struct{}) {
|
||||||
|
if ch == nil {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
defer st.clearWriteWait(ch)
|
||||||
|
deadline := time.NewTimer(2 * time.Second)
|
||||||
|
defer deadline.Stop()
|
||||||
|
select {
|
||||||
|
case <-ch:
|
||||||
|
case <-st.downStop:
|
||||||
|
case <-deadline.C:
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func (st *connState) notePacketSent(pk packets.Packet) {
|
||||||
|
if pk.FixedHeader.Type == packets.Publish {
|
||||||
|
for {
|
||||||
|
cur := st.wirePending.Load()
|
||||||
|
if cur <= 0 {
|
||||||
|
break
|
||||||
|
}
|
||||||
|
if st.wirePending.CompareAndSwap(cur, cur-1) {
|
||||||
|
break
|
||||||
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
st.mu.Lock()
|
||||||
|
ch := st.writeWaitCh
|
||||||
|
pid := st.writeWaitPID
|
||||||
|
want := st.writeWaitPayload
|
||||||
|
st.mu.Unlock()
|
||||||
|
if ch == nil || pk.FixedHeader.Type != packets.Publish {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
match := false
|
||||||
|
if pid != 0 {
|
||||||
|
match = pk.PacketID == pid
|
||||||
|
} else if want != nil {
|
||||||
|
match = bytes.Equal(pk.Payload, want)
|
||||||
|
}
|
||||||
|
if !match {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
st.mu.Lock()
|
||||||
|
if st.writeWaitCh == ch {
|
||||||
|
st.writeWaitCh = nil
|
||||||
|
st.writeWaitPayload = nil
|
||||||
|
st.writeWaitPID = 0
|
||||||
|
}
|
||||||
|
st.mu.Unlock()
|
||||||
|
select {
|
||||||
|
case <-ch:
|
||||||
|
default:
|
||||||
|
close(ch)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func (st *connState) lookupInflightPID(payload []byte) (uint16, bool) {
|
||||||
|
if st.client == nil || st.client.State.Inflight == nil {
|
||||||
|
return 0, false
|
||||||
|
}
|
||||||
|
for _, pk := range st.client.State.Inflight.GetAll(false) {
|
||||||
|
if pk.FixedHeader.Type != packets.Publish {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
if bytes.Equal(pk.Payload, payload) {
|
||||||
|
return pk.PacketID, pk.PacketID != 0
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return 0, false
|
||||||
}
|
}
|
||||||
|
|
||||||
func (st *connState) signalSent(item downItem) {
|
func (st *connState) signalSent(item downItem) {
|
||||||
|
|||||||
@@ -175,14 +175,11 @@ func (h *nixHook) OnSubscribed(cl *mqtt.Client, pk packets.Packet, reasonCodes [
|
|||||||
}
|
}
|
||||||
|
|
||||||
func (h *nixHook) OnPacketSent(cl *mqtt.Client, pk packets.Packet, _ []byte) {
|
func (h *nixHook) OnPacketSent(cl *mqtt.Client, pk packets.Packet, _ []byte) {
|
||||||
if pk.FixedHeader.Type != packets.Publish {
|
|
||||||
return
|
|
||||||
}
|
|
||||||
h.b.connsMu.RLock()
|
h.b.connsMu.RLock()
|
||||||
st := h.b.byClient[cl]
|
st := h.b.byClient[cl]
|
||||||
h.b.connsMu.RUnlock()
|
h.b.connsMu.RUnlock()
|
||||||
if st != nil {
|
if st != nil {
|
||||||
st.sentPub.Add(1)
|
st.notePacketSent(pk)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -254,6 +251,7 @@ func (h *nixHook) OnDisconnect(cl *mqtt.Client, err error, _ bool) {
|
|||||||
lk.Lock()
|
lk.Lock()
|
||||||
st.stopDownLoop()
|
st.stopDownLoop()
|
||||||
lk.Unlock()
|
lk.Unlock()
|
||||||
|
st.wirePending.Store(0)
|
||||||
h.b.releaseAllLarge(st)
|
h.b.releaseAllLarge(st)
|
||||||
h.b.cancelHandshakeDeadline(st.endpointID, st.connID)
|
h.b.cancelHandshakeDeadline(st.endpointID, st.connID)
|
||||||
|
|
||||||
|
|||||||
@@ -296,7 +296,7 @@ export function deleteGroup(id: string) {
|
|||||||
|
|
||||||
export function addGroupMembers(id: string, memberIds: string[]) {
|
export function addGroupMembers(id: string, memberIds: string[]) {
|
||||||
return run(() =>
|
return run(() =>
|
||||||
requestAdmin<{ failed: GroupFailed[]; added: number }>(
|
requestAdmin<{ failed: GroupFailed[] }>(
|
||||||
`/api/admin/groups/${encodeURIComponent(id)}/members`,
|
`/api/admin/groups/${encodeURIComponent(id)}/members`,
|
||||||
{
|
{
|
||||||
method: "POST",
|
method: "POST",
|
||||||
|
|||||||
+2
-4
@@ -691,14 +691,13 @@ export const mockApi = {
|
|||||||
return {};
|
return {};
|
||||||
},
|
},
|
||||||
|
|
||||||
async addGroupMembers(id: string, memberIds: string[]): Promise<{ failed: GroupFailed[]; added: number }> {
|
async addGroupMembers(id: string, memberIds: string[]): Promise<{ failed: GroupFailed[] }> {
|
||||||
requireSession();
|
requireSession();
|
||||||
const g = groups.find((x) => x.id === id);
|
const g = groups.find((x) => x.id === id);
|
||||||
if (!g) {
|
if (!g) {
|
||||||
throw new ApiError("not_found", "群不存在", 404);
|
throw new ApiError("not_found", "群不存在", 404);
|
||||||
}
|
}
|
||||||
const failed: GroupFailed[] = [];
|
const failed: GroupFailed[] = [];
|
||||||
let added = 0;
|
|
||||||
for (const mid of memberIds) {
|
for (const mid of memberIds) {
|
||||||
if (!endpoints.some((e) => e.id === mid)) {
|
if (!endpoints.some((e) => e.id === mid)) {
|
||||||
failed.push({ id: mid, code: "not_found" });
|
failed.push({ id: mid, code: "not_found" });
|
||||||
@@ -706,10 +705,9 @@ export const mockApi = {
|
|||||||
}
|
}
|
||||||
if (!g.members.some((m) => m.id === mid)) {
|
if (!g.members.some((m) => m.id === mid)) {
|
||||||
g.members.push({ id: mid, joined_at_ms: now() });
|
g.members.push({ id: mid, joined_at_ms: now() });
|
||||||
added++;
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
return { failed, added };
|
return { failed };
|
||||||
},
|
},
|
||||||
|
|
||||||
async removeGroupMember(id: string, endpointId: string): Promise<Record<string, never>> {
|
async removeGroupMember(id: string, endpointId: string): Promise<Record<string, never>> {
|
||||||
|
|||||||
@@ -233,15 +233,9 @@ async function onAddMembers() {
|
|||||||
if (!ids.length) return;
|
if (!ids.length) return;
|
||||||
const res = await addGroupMembers(detail.value.id, ids);
|
const res = await addGroupMembers(detail.value.id, ids);
|
||||||
if (res.failed.length) {
|
if (res.failed.length) {
|
||||||
if (res.added > 0) {
|
message.warning(`部分失败:${formatFailed(res.failed)}`);
|
||||||
message.warning(`已加入 ${res.added} 人,部分失败:${formatFailed(res.failed)}`);
|
|
||||||
} else {
|
|
||||||
message.warning(`部分失败:${formatFailed(res.failed)}`);
|
|
||||||
}
|
|
||||||
} else if (res.added === 0) {
|
|
||||||
message.info("没有新成员加入");
|
|
||||||
} else {
|
} else {
|
||||||
message.success(`已加人 ${res.added} 人`);
|
message.success("已加人");
|
||||||
}
|
}
|
||||||
await loadDetail(detail.value.id);
|
await loadDetail(detail.value.id);
|
||||||
await load();
|
await load();
|
||||||
|
|||||||
Reference in New Issue
Block a user